Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update msquic #81742

Merged
merged 6 commits into from
Mar 1, 2023
Merged

update msquic #81742

merged 6 commits into from
Mar 1, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 7, 2023

This updates Quic project to consume our binaries by default for windows build. The dotnet/msquic was updated to produce upcoming 2.2 version (built from main)
I also updated version of official msquic binaries. There don't seems to be any critical fixes but it feels right to point it at latest release.

@wfurt wfurt added this to the 8.0.0 milestone Feb 7, 2023
@wfurt wfurt requested a review from a team February 7, 2023 05:02
@wfurt wfurt self-assigned this Feb 7, 2023
@ghost
Copy link

ghost commented Feb 7, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This updates Quic project to consume our binaries by default for windows build. The dotnet/msquic was updated to produce upcoming 2.2 version (built from main)
I also updated version of official msquic binaries. There don't seems to be any critical fixes but it feels right to point it at latest release.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: 8.0.0

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wfurt
Copy link
Member Author

wfurt commented Feb 8, 2023

windows crash looks suspicious. I will investigate...

@CarnaViire
Copy link
Member

Any news on this @wfurt ?

@wfurt
Copy link
Member Author

wfurt commented Feb 20, 2023

no. We may need to pick up more changes from MsQuic so I may wait for that before diving deep.

@wfurt
Copy link
Member Author

wfurt commented Feb 28, 2023

all the test failures are independent. Let me know if it is ok to move this forward @ManickaP @CarnaViire

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants