[QUIC] Added tests to check IsSupported. #81481

ManickaP · 2023-02-01T15:39:34Z

On Windows, straightforward.

On Linux, I'm probing system for libmsquic existence and if so then checking IsSupported. This should discover installed libmsquic without corresponding dependencies like openssl.
I'm also adding test that expects libmsquic on every tested Linux we have in the matrix and suppressing for known gaps.

Contributes to #81447

ghost · 2023-02-01T15:39:46Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

On Windows, straightforward.

On Linux, I'm probing system for libmsquic existence and if so then checking IsSupported. I couldn't come up with better way to do this unless we want to explicitly list the docker images which should have libmsquic installed.
This should at least discover installed libmsquic without corresponding openssl (i.e. missing dependency).

Contributes to #81447

Adding NO MERGE as this should fail now on Win11.

Author:	ManickaP
Assignees:	ManickaP
Labels:	`NO-MERGE`, `area-System.Net.Quic`
Milestone:	-

ManickaP · 2023-02-01T15:58:14Z

Thinking about this some more and I think we should be more aggressive. On Linux, on every docker image, we should expect libmsquic. If it's not there, we should add it. If we cannot, we should file an issue and disable the test temporarily, e.g. dotnet/dotnet-docker#4322 (comment).

src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs

…nglefile

ManickaP · 2023-02-06T10:22:50Z

src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs

@@ -20,20 +21,33 @@ public void UnsupportedPlatforms_ThrowsPlatformNotSupportedException()
            Assert.ThrowsAsync<PlatformNotSupportedException>(async () => await CreateQuicConnection(new IPEndPoint(IPAddress.Loopback, 0)));
        }

+        [ActiveIssue("https://github.com/dotnet/runtime/issues/73290", typeof(PlatformDetection), nameof(PlatformDetection.IsSingleFile))]


Based on this run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=158551&view=ms.vss-test-web.build-test-results-tab&runId=3276022&resultId=132009&paneView=debug
it looks like this part works.

wfurt · 2023-02-08T00:45:05Z

ATM depends on #81742

why?

ManickaP · 2023-02-08T10:04:48Z

ATM depends on #81742

why?

Ohh we don't, you have too many PRs named "update msquic" 😄

We need to pull in microsoft/msquic#3394 for alpine, which was merged into transport in dotnet/msquic#120.

Do we know if it got propagated into the helix images already?

wfurt · 2023-02-08T18:44:35Z

alpine-3.17-helix-amd64-20230208010446-6d7b22b and alpine-3.15-helix-amd64-20230208010517-6d7b22b should be ready. However, they did not roll into production yet so it is not possible to use the simplified stamp-less version like alpine-3.17-helix-amd64. Since there probably will be more changes we may not wait.
We can do it as part of this or I was planning to roll it in as contribution to #81801.

wfurt · 2023-02-08T18:47:41Z

the image tags are waiting for dotnet/dotnet-buildtools-prereqs-docker#790. Should hopefully happen today.

ManickaP · 2023-02-09T11:10:54Z

/azp run runtime-extra-platforms

ManickaP · 2023-02-09T11:11:01Z

/azp run runtime-libraries-coreclr outerloop

ManickaP · 2023-02-09T17:38:09Z

/azp run runtime-extra-platforms

ManickaP · 2023-02-09T17:38:19Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-02-09T17:38:28Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2023-02-09T17:38:31Z

Azure Pipelines successfully started running 1 pipeline(s).

wfurt · 2023-02-09T19:41:50Z

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs

@@ -52,6 +55,7 @@ public static partial class PlatformDetection
        public static bool IsRedHatFamily => IsRedHatFamilyAndVersion();
        public static bool IsNotRedHatFamily => !IsRedHatFamily;
        public static bool IsRedHatFamily7 => IsRedHatFamilyAndVersion(7);
+        public static bool IsCentos7 => IsDistroAndVersion("centos", 7);


can we use the IsRedHatFamily7 above?

It includes RHEL (or rather excludes from testing) as well. So no, I don't think that's advisable as we want exact list of images that are failing.

they should be basically identical. but I guess they are not:
dotnet/arcade#10253 (comment)

Perhaps something we should investigate. We have at least one of the runs in container so it should be easy to check.

ManickaP · 2023-02-10T10:33:03Z

Errors unrelated:

runtime:
- Failures in SSL Stream tests: There are no more endpoints available in the endpoint mapper. #74838: spanish + security
- [wasm][debugger] Multiple tests failing on rolling builds on Windows #81792: debugger + wasm
extra-platforms:
- System.Collections.Concurrent.Tests.ConcurrentDictionary_Generic_Tests_string_string.NonRandomizedToRandomizedUpgrade_FunctionsCorrectly fails on extra-platforms #81945: concurrent dictionary null ref
- Failures in SSL Stream tests: There are no more endpoints available in the endpoint mapper. #74838: spanish + security
- Harden and re-enable DualMode socket tests #80715: android + dual mode sockets
outerloop:
- too many, but none regarding QUIC

ManickaP · 2023-02-10T10:36:03Z

This is ready for review: @CarnaViire @wfurt

CarnaViire

LGTM, thanks!

ManickaP added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 1, 2023

dotnet-issue-labeler bot added the area-System.Net.Quic label Feb 1, 2023

ghost assigned ManickaP Feb 1, 2023

ManickaP requested review from rzikm and wfurt February 1, 2023 15:39

carlossanlop reviewed Feb 1, 2023

View reviewed changes

src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs Show resolved Hide resolved

ManickaP mentioned this pull request Feb 1, 2023

[release/8.0-preview1] [QUIC] Fix conditions to bin place msquic.dll for Windows builds #81492

Merged

wfurt reviewed Feb 1, 2023

View reviewed changes

src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs Outdated Show resolved Hide resolved

ManickaP added 2 commits February 3, 2023 12:52

Added tests to check IsSupported.

a2f2b8a

Use find to locate msquic lib; Use ActiveIssue to skip win test on si…

b1615d8

…nglefile

ManickaP force-pushed the mapichov/quic-test-supported branch from cf63fb4 to b1615d8 Compare February 3, 2023 12:27

This comment was marked as off-topic.

Sign in to view

build-analysis bot mentioned this pull request Feb 3, 2023

Tracking issue for CI build timeouts #76454

Closed

wfurt mentioned this pull request Feb 3, 2023

build libssl with no-seed microsoft/msquic#3394

Merged

ManickaP commented Feb 6, 2023

View reviewed changes

Strict test for Linux containers to check where we're missing libmsquic

da36829

build-analysis bot mentioned this pull request Feb 8, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

5 tasks

ManickaP force-pushed the mapichov/quic-test-supported branch from 9b49aae to bac381e Compare February 8, 2023 18:27

build-analysis bot mentioned this pull request Feb 8, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

Updated readme

f9241c4

ManickaP force-pushed the mapichov/quic-test-supported branch from bac381e to f9241c4 Compare February 8, 2023 19:56

Some more matrix testing of msquic presence

2ea6ef0

ManickaP force-pushed the mapichov/quic-test-supported branch from 73de4ae to 2ea6ef0 Compare February 9, 2023 11:09

dotnet deleted a comment from azure-pipelines bot Feb 9, 2023

ManickaP mentioned this pull request Feb 9, 2023

[QUIC] Missing libmsquic on tested platforms #81901

Closed

4 tasks

Suppressed failing tests against failing containers

c7276e2

wfurt reviewed Feb 9, 2023

View reviewed changes

ManickaP mentioned this pull request Feb 10, 2023

System.Collections.Concurrent.Tests.ConcurrentDictionary_Generic_Tests_string_string.NonRandomizedToRandomizedUpgrade_FunctionsCorrectly fails on extra-platforms #81945

Closed

ManickaP requested a review from CarnaViire February 10, 2023 10:35

ManickaP removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 10, 2023

CarnaViire approved these changes Feb 10, 2023

View reviewed changes

ManickaP merged commit 5a62a79 into dotnet:main Feb 10, 2023

ManickaP deleted the mapichov/quic-test-supported branch February 10, 2023 17:08

tmds mentioned this pull request Feb 14, 2023

SupportedLinuxPlatforms_IsSupportedIsTrue fails on distros without quic #82077

Closed

ghost locked as resolved and limited conversation to collaborators Mar 13, 2023

karelz added this to the 8.0.0 milestone Mar 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QUIC] Added tests to check IsSupported. #81481

[QUIC] Added tests to check IsSupported. #81481

ManickaP commented Feb 1, 2023 •

edited

Loading

ghost commented Feb 1, 2023

ManickaP commented Feb 1, 2023

This comment was marked as off-topic.

ManickaP Feb 6, 2023

wfurt commented Feb 8, 2023

ManickaP commented Feb 8, 2023 •

edited

Loading

wfurt commented Feb 8, 2023

wfurt commented Feb 8, 2023

ManickaP commented Feb 9, 2023

ManickaP commented Feb 9, 2023

ManickaP commented Feb 9, 2023

ManickaP commented Feb 9, 2023

azure-pipelines bot commented Feb 9, 2023

azure-pipelines bot commented Feb 9, 2023

wfurt Feb 9, 2023

ManickaP Feb 10, 2023

wfurt Feb 10, 2023

ManickaP commented Feb 10, 2023

ManickaP commented Feb 10, 2023

CarnaViire left a comment

[QUIC] Added tests to check IsSupported. #81481

[QUIC] Added tests to check IsSupported. #81481

Conversation

ManickaP commented Feb 1, 2023 • edited Loading

ghost commented Feb 1, 2023

ManickaP commented Feb 1, 2023

This comment was marked as off-topic.

ManickaP Feb 6, 2023

Choose a reason for hiding this comment

wfurt commented Feb 8, 2023

ManickaP commented Feb 8, 2023 • edited Loading

wfurt commented Feb 8, 2023

wfurt commented Feb 8, 2023

ManickaP commented Feb 9, 2023

ManickaP commented Feb 9, 2023

ManickaP commented Feb 9, 2023

ManickaP commented Feb 9, 2023

azure-pipelines bot commented Feb 9, 2023

azure-pipelines bot commented Feb 9, 2023

wfurt Feb 9, 2023

Choose a reason for hiding this comment

ManickaP Feb 10, 2023

Choose a reason for hiding this comment

wfurt Feb 10, 2023

Choose a reason for hiding this comment

ManickaP commented Feb 10, 2023

ManickaP commented Feb 10, 2023

CarnaViire left a comment

Choose a reason for hiding this comment

ManickaP commented Feb 1, 2023 •

edited

Loading

ManickaP commented Feb 8, 2023 •

edited

Loading