[wasm] Initial emscripten 3.1.30 support #81215

radekdoulik · 2023-01-26T13:37:44Z

Part of #80784 implementation

radekdoulik · 2023-01-26T13:38:36Z

It now builds, we need updated icu and thus docker images to be able to run anything yet.

…ipten-3-1-30

radekdoulik · 2023-02-10T13:56:53Z

wasm-ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) /__w/1/s/.packages/microsoft.netcore.runtime.icu.transport/8.0.0-preview.2.23108.1/runtimes/browser-wasm/native/lib/libicuuc.a(udata.ao): undefined symbol: icudt68_dat

@maraf looks like the undefined icu symbol causes problem with newer emscripten. could you please take a look?

maraf · 2023-02-13T12:52:48Z

wasm-ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) /__w/1/s/.packages/microsoft.netcore.runtime.icu.transport/8.0.0-preview.2.23108.1/runtimes/browser-wasm/native/lib/libicuuc.a(udata.ao): undefined symbol: icudt68_dat

Emscripten changed a default value of LLD_REPORT_UNDEFINED (to true) in emscripten-core/emscripten#16003

It's an undefined symbol in ICU, because we are not linking in a lib, that should in the end be linked out. Updated version of emscripten has by default turned on the LLD_REPORT_UNDEFINED .

Should be `--lto-O0`

…ipten-3-1-30

radekdoulik · 2023-02-21T15:14:43Z

@radical could you please take a look at problem with certificates on windows build?

##[error]urllib.error.URLError(0,0): error [SSL: (NETCORE_ENGINEERING_TELEMETRY=Build) CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)>

Looks like installing the certifi doesn't help anymore. https://github.com/dotnet/runtime/blob/main/eng/pipelines/mono/update-machine-certs.ps1#L3

urllib.error.URLError : <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)> [D:\a\_work\1\s\src\mono\sample\wasm\browser-advanced\Wasm.Advanced.Sample.csproj]
##[error]urllib.error.URLError(0,0): error [SSL: (NETCORE_ENGINEERING_TELEMETRY=Build) CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)>
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Native.targets(333,5): error MSB3073: The command "embuilder.bat build MINIMAL" exited with code 1. [D:\a\_work\1\s\src\mono\sample\wasm\browser-advanced\Wasm.Advanced.Sample.csproj]
##[error]src\mono\wasm\build\WasmApp.Native.targets(333,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command "embuilder.bat build MINIMAL" exited with code 1.

Build FAILED.```

lambdageek · 2023-02-21T20:30:41Z

src/mono/wasm/build/WasmApp.Native.targets

@@ -325,10 +325,12 @@
    <WriteLinesToFile Lines="@(_EmccCFlags)" File="$(_EmccCompileRsp)" Overwrite="true" WriteOnlyWhenDifferent="true" />
    <ItemGroup>
      <FileWrites Include="$(_EmccCompileRsp)" />
+      <EmscriptenMinimalBuildEnvVars Include="@(EmscriptenEnvVars)" />
+      <EmscriptenMinimalBuildEnvVars Include="FROZEN_CACHE=" />


The Microsoft.NET.Runtime.Emscripten.Cache SDK overrides the WasmCachePath property. If we're unfreezing the cache here does that mean we can overwrite the nuget contents sometimes?

See dotnet/emsdk#211

I think we do that on purpose IIRC

runtime/src/mono/wasm/build/WasmApp.Native.targets

Lines 332 to 333 in 9f145a3



<Exec Command="$(_EmBuilder) build MINIMAL" EnvironmentVariables="@(EmscriptenMinimalBuildEnvVars)" StandardOutputImportance="Low" StandardErrorImportance="Low" />

Is that right @radical?

the freezing/build was required before we were shipping the cache package we should probably review the logic there

to provide more context: the reason for the change itself is that the default value of FROZEN_CACHE proably changed with newer emscripten, and so the warming embuilder build MINIMAL build was now failing, complaining about not being able to update frozen cache.

This whole does need to be reviewed again. If the workload is installed in non-user-writable location then how does the build behave? How does the FROZEN_CACHE setting affect things? I have opened #83281 .

radekdoulik · 2023-02-23T15:36:39Z

@lambdageek @vargaz I see these assertion crashes in some tests:

        [wasm test-browser] [19:58:47] info: Application arguments: --run rebuild_flags_Release.dll
        [wasm test-browser] [19:58:47] info: browser: [main] Console websocket connected.
        [wasm test-browser] [19:58:47] fail: [out of order message from the browser]: http://127.0.0.1:33849/dotnet.js 2:201933 Uncaught ExitStatus: Program terminated with exit(1)
        [wasm test-browser] [19:58:47] fail: [out of order message from the browser]: http://127.0.0.1:33849/dotnet.js 2:201659 Uncaught ExitStatus: Program terminated with exit(1)
        [wasm test-browser] [19:58:47] fail: [out of order message from the browser]: http://127.0.0.1:33849/test-main.js 342:0 Uncaught ExitStatus: Program terminated with exit(1)
        [wasm test-browser] [19:58:47] fail: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/utils/mono-threads.c:514, condition `<disabled>' not met
        [wasm test-browser]                  
        [wasm test-browser]                      at se (http://127.0.0.1:33849/dotnet.js:3:14137)
        [wasm test-browser]                      at ie (http://127.0.0.1:33849/dotnet.js:3:14427)
        [wasm test-browser]                      at wasm_trace_logger (http://127.0.0.1:33849/dotnet.wasm:wasm-function[11526]:0x213fdb)
        [wasm test-browser]                      at eglib_log_adapter (http://127.0.0.1:33849/dotnet.wasm:wasm-function[560]:0x38d8d)
        [wasm test-browser]                      at monoeg_g_logv_nofree (http://127.0.0.1:33849/dotnet.wasm:wasm-function[455]:0x360e6)
        [wasm test-browser]                      at monoeg_assertion_message (http://127.0.0.1:33849/dotnet.wasm:wasm-function[459]:0x36212)
        [wasm test-browser]                      at mono_assertion_message (http://127.0.0.1:33849/dotnet.wasm:wasm-function[461]:0x3625b)
        [wasm test-browser]                      at mono_assertion_message_disabled (http://127.0.0.1:33849/dotnet.wasm:wasm-function[460]:0x3622b)
        [wasm test-browser]                      at mono_thread_info_attach (http://127.0.0.1:33849/dotnet.wasm:wasm-function[697]:0x3d738)
        [wasm test-browser]                      at sgen_client_init (http://127.0.0.1:33849/dotnet.wasm:wasm-function[3494]:0xc848d)
        [wasm test-browser] [19:58:47] warn: program exited (with status: 1), but EXIT_RUNTIME is not set, so halting execution but not exiting the runtime or preventing further async execution (build with EXIT_RUNTIME=1, if you want a true shutdown)
        [wasm test-browser] [19:58:47] warn: MONO_WASM: mono_wasm_load_runtime () failed: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] warn: MONO_WASM: Error in mono_wasm_before_user_runtime_initialized: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] warn: MONO_WASM: onRuntimeInitializedAsync() failed: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] fail: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] fail: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] fail: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] info: WASM EXIT 1
        [wasm test-browser] [19:58:47] dbug: Reached wasm exit
        [wasm test-browser] [19:58:47] info: Waiting to flush log messages with a timeout of 120 secs ..
        [wasm test-browser] [19:58:47] warn: Message processor is not running anymore.

Do you know what it might be? Should this be called in non-threaded build too?

https://github.com/radekdoulik/runtime/blob/d6f6a4ef2d9b4a83bd68bc19f9bd7c8f8510cb52/src/mono/mono/utils/mono-threads.c#L514

lambdageek · 2023-02-23T15:47:48Z

@lambdageek @vargaz I see these assertion crashes in some tests:

        [wasm test-browser] [19:58:47] info: Application arguments: --run rebuild_flags_Release.dll
        [wasm test-browser] [19:58:47] info: browser: [main] Console websocket connected.
        [wasm test-browser] [19:58:47] fail: [out of order message from the browser]: http://127.0.0.1:33849/dotnet.js 2:201933 Uncaught ExitStatus: Program terminated with exit(1)
        [wasm test-browser] [19:58:47] fail: [out of order message from the browser]: http://127.0.0.1:33849/dotnet.js 2:201659 Uncaught ExitStatus: Program terminated with exit(1)
        [wasm test-browser] [19:58:47] fail: [out of order message from the browser]: http://127.0.0.1:33849/test-main.js 342:0 Uncaught ExitStatus: Program terminated with exit(1)
        [wasm test-browser] [19:58:47] fail: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/utils/mono-threads.c:514, condition `<disabled>' not met
        [wasm test-browser]                  
        [wasm test-browser]                      at se (http://127.0.0.1:33849/dotnet.js:3:14137)
        [wasm test-browser]                      at ie (http://127.0.0.1:33849/dotnet.js:3:14427)
        [wasm test-browser]                      at wasm_trace_logger (http://127.0.0.1:33849/dotnet.wasm:wasm-function[11526]:0x213fdb)
        [wasm test-browser]                      at eglib_log_adapter (http://127.0.0.1:33849/dotnet.wasm:wasm-function[560]:0x38d8d)
        [wasm test-browser]                      at monoeg_g_logv_nofree (http://127.0.0.1:33849/dotnet.wasm:wasm-function[455]:0x360e6)
        [wasm test-browser]                      at monoeg_assertion_message (http://127.0.0.1:33849/dotnet.wasm:wasm-function[459]:0x36212)
        [wasm test-browser]                      at mono_assertion_message (http://127.0.0.1:33849/dotnet.wasm:wasm-function[461]:0x3625b)
        [wasm test-browser]                      at mono_assertion_message_disabled (http://127.0.0.1:33849/dotnet.wasm:wasm-function[460]:0x3622b)
        [wasm test-browser]                      at mono_thread_info_attach (http://127.0.0.1:33849/dotnet.wasm:wasm-function[697]:0x3d738)
        [wasm test-browser]                      at sgen_client_init (http://127.0.0.1:33849/dotnet.wasm:wasm-function[3494]:0xc848d)
        [wasm test-browser] [19:58:47] warn: program exited (with status: 1), but EXIT_RUNTIME is not set, so halting execution but not exiting the runtime or preventing further async execution (build with EXIT_RUNTIME=1, if you want a true shutdown)
        [wasm test-browser] [19:58:47] warn: MONO_WASM: mono_wasm_load_runtime () failed: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] warn: MONO_WASM: Error in mono_wasm_before_user_runtime_initialized: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] warn: MONO_WASM: onRuntimeInitializedAsync() failed: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] fail: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] fail: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] fail: {"name":"ExitStatus","message":"Program terminated with exit(1)","status":1}
        [wasm test-browser] [19:58:47] info: WASM EXIT 1
        [wasm test-browser] [19:58:47] dbug: Reached wasm exit
        [wasm test-browser] [19:58:47] info: Waiting to flush log messages with a timeout of 120 secs ..
        [wasm test-browser] [19:58:47] warn: Message processor is not running anymore.

Do you know what it might be? Should this be called in non-threaded build too?

https://github.com/radekdoulik/runtime/blob/d6f6a4ef2d9b4a83bd68bc19f9bd7c8f8510cb52/src/mono/mono/utils/mono-threads.c#L514

@radekdoulik
that's g_assert(&staddr). So mono_threads_platform_get_stack_bounds isn't working correctly for some reason. With threads disabled that calls wasm_get_stack_base which is emscripten_stack_get_end() - did something change about this function so it returns 0 sometimes?

pavelsavara · 2023-02-23T15:50:56Z

Maybe https://github.com/emscripten-core/emscripten/pull/18057/files

The linker puts stack at 0 sometime, so just check that the stack size is not zero.

radekdoulik · 2023-02-24T12:19:50Z

The emscripten is now setting stack bounds by the linker generated values. The linker now sometimes puts the stack at the beginning of the linear memory, like in one of the wbt tests, when rebuilding with link -O0 flag.

> wa-info.exe -d -f emscripten_stack_init artifacts\bin\Wasm.Build.Tests\Release\net8.0\browser-wasm\wbt\kk2zltlt.suu\bin\Release\net8.0\browser-wasm\AppBundle\dotnet.wasm
(func emscripten_stack_init)
 i32.const 65536
 global.set $__stack_base
 i32.const 0
 i32.const 15
 i32.add
 i32.const -1
 i32.and
 global.set $__stack_end

The dotnet.wasm before rebuild looks like:

> wa-info.exe -d -f emscripten_stack_init artifacts\bin\Wasm.Build.Tests\Release\net8.0\browser-wasm\wbt\kk2zltlt.suu\dotnet.1.wasm
(func emscripten_stack_init)
 i32.const 651712
 global.set $__stack_base
 i32.const 586176
 global.set $__stack_end

The app seems to run fine locally, so I removed the assert checking the beginning of the stack memory area. Let see how it will look on CI.

pavelsavara · 2023-02-24T14:11:40Z

src/mono/wasm/runtime/types/emscripten.ts

@@ -37,8 +38,8 @@ export declare interface EmscriptenModule {
    _free(ptr: VoidPtr): void;

    // this should match emcc -s EXPORTED_RUNTIME_METHODS
-    print(message: string): void;
-    printErr(message: string): void;
+    out(message: string): void;


This will probably break Blazor.

src/mono/mono/utils/mono-threads.c

pavelsavara · 2023-02-24T14:14:10Z

src/mono/wasm/runtime/dotnet.d.ts

@@ -45,8 +45,8 @@ declare interface EmscriptenModule {
    HEAPF64: Float64Array;
    _malloc(size: number): VoidPtr;
    _free(ptr: VoidPtr): void;
-    print(message: string): void;
-    printErr(message: string): void;
+    out(message: string): void;


This is API breaking change.

Do we consider this API stable?

We can still get the deprecated ones with -sINCOMING_MODULE_JS_API=print,printErr if needed.

Do we consider this API stable?

No

We can still get the deprecated ones with -sINCOMING_MODULE_JS_API=print,printErr if needed.

Yes please, I think these 2 are widely enough used even by Uno.

They could be removed from .d.ts but should keep working.

I'm not sure we want to be in the business of maintaining unstable emscripten apis that emscripten has dropped long term but we should document the change and short term compat is fine.

src/mono/wasm/runtime/memory.ts

This reverts commit 889d036.

lewing · 2023-03-10T01:35:51Z

it's green! 🎊

…ipten-3-1-30

kg · 2023-03-10T21:02:36Z

eng/testing/WasmRunnerTemplate.sh

+		if [[ "$SCENARIO" == "WasmTestOnNodeJS" || "$SCENARIO" == "wasmtestonnodejs" ]]; then
+			JS_ENGINE_ARGS="--engine-arg=--stack-trace-limit=1000"
+		else
+			JS_ENGINE_ARGS="--engine-arg=--stack-trace-limit=1000 --engine-arg=--experimental-wasm-bigint"


While we're at it shouldn't we enable SIMD?

It is not needed here, shouldn't harm though. I can do it in the follow up PR, to avoid more icu/emsdk package switch backs.

radical · 2023-03-10T21:15:50Z

src/mono/wasm/build/WasmApp.Native.targets

@@ -322,10 +323,12 @@
    <WriteLinesToFile Lines="@(_EmccCFlags)" File="$(_EmccCompileRsp)" Overwrite="true" WriteOnlyWhenDifferent="true" />
    <ItemGroup>
      <FileWrites Include="$(_EmccCompileRsp)" />
+      <EmscriptenMinimalBuildEnvVars Include="@(EmscriptenEnvVars)" />


It would be clearer to rename this to a private name like _EmscriptenEnvVarsForBuildMinimal.

I can do it in the follow up PR, to avoid more icu/emsdk package switch backs.

radical · 2023-03-10T21:21:29Z

/azp run runtime-wasm

azure-pipelines · 2023-03-10T21:21:47Z

Azure Pipelines successfully started running 1 pipeline(s).

radical

🥳 🎉

lewing · 2023-03-11T00:41:22Z

Failures are known

[wasm] Initial emscripten 3.1.30 support

ed80ed3

dotnet-issue-labeler bot added the area-System.Runtime.InteropServices.JavaScript label Jan 26, 2023

ghost assigned radekdoulik Jan 26, 2023

radekdoulik added 4 commits February 10, 2023 12:42

Update icu dependency

96d59b8

Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-emscr…

6512388

…ipten-3-1-30

Update emsdk dependency

0d522ba

Use new docker images

f5a205e

build-analysis bot mentioned this pull request Feb 10, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

Add "icudt68_dat" as JS imported function.

7d2e8eb

It's an undefined symbol in ICU, because we are not linking in a lib, that should in the end be linked out. Updated version of emscripten has by default turned on the LLD_REPORT_UNDEFINED .

build-analysis bot mentioned this pull request Feb 13, 2023

Tracking issue for CI build timeouts #76454

Closed

maraf and others added 6 commits February 14, 2023 09:18

Drop build-time support for undefined icudt68_dat.

44ede5e

Fix linker options

ab5c12e

Should be `--lto-O0`

Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-emscr…

2e74270

…ipten-3-1-30

Fix remaining conflict

e275857

Limit new warnings option to browser

54dfd24

Try to force reinstall of certifi

c302891

Unset FROZEN_CACHE for embuilder build MINIMAL

9f145a3

lambdageek reviewed Feb 21, 2023

View reviewed changes

Update emsdk deps

d6f6a4e

Remove assert for stack address

5067a1d

The linker puts stack at 0 sometime, so just check that the stack size is not zero.

pavelsavara reviewed Feb 24, 2023

View reviewed changes

build-analysis bot mentioned this pull request Feb 24, 2023

CI legs failing with "Assembly 'illink' is missing dependency 'Mono.Cecil'" error #82611

Closed

radekdoulik added 2 commits March 9, 2023 17:59

Update emsdk deps

fda96f7

Update icu deps

55fddbf

build-analysis bot mentioned this pull request Mar 9, 2023

[wasm][debugger] DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment failing #64188

Closed

radekdoulik and others added 2 commits March 9, 2023 22:58

Revert "Add -s INCOMING_MODULE_JS_API=print,printErr"

0da18d5

This reverts commit 889d036.

Merge branch 'main' into pr-wasm-emscripten-3-1-30

eb7be72

build-analysis bot mentioned this pull request Mar 10, 2023

[release/6.0] Doublelinklist GC failures on Mono #83245

Closed

radekdoulik added 4 commits March 10, 2023 17:59

Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-emscr…

3fcf10f

…ipten-3-1-30

Update emsdk deps

6420bf6

Update icu deps

58b5c1d

Disable one more file related test

2a446e1

radekdoulik marked this pull request as ready for review March 10, 2023 19:53

radekdoulik requested review from radical, kg, vargaz and marek-safar as code owners March 10, 2023 19:53

kg reviewed Mar 10, 2023

View reviewed changes

radical reviewed Mar 10, 2023

View reviewed changes

radical approved these changes Mar 10, 2023

View reviewed changes

Merge branch 'main' into pr-wasm-emscripten-3-1-30

ef6443c

lewing merged commit fe95ddb into dotnet:main Mar 11, 2023

kg mentioned this pull request Mar 15, 2023

[wasm] System.Runtime.Tests exiting silently on main #83443

Closed

ghost locked as resolved and limited conversation to collaborators Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] Initial emscripten 3.1.30 support #81215

[wasm] Initial emscripten 3.1.30 support #81215

radekdoulik commented Jan 26, 2023 •

edited

Loading

radekdoulik commented Jan 26, 2023

radekdoulik commented Feb 10, 2023

maraf commented Feb 13, 2023

radekdoulik commented Feb 21, 2023 •

edited

Loading

lambdageek Feb 21, 2023

lambdageek Feb 21, 2023

radekdoulik Feb 22, 2023

lewing Feb 22, 2023

radekdoulik Feb 22, 2023

radical Mar 10, 2023

radekdoulik commented Feb 23, 2023 •

edited

Loading

lambdageek commented Feb 23, 2023

pavelsavara commented Feb 23, 2023

radekdoulik commented Feb 24, 2023

pavelsavara Feb 24, 2023

pavelsavara Feb 24, 2023

radekdoulik Feb 27, 2023

pavelsavara Feb 27, 2023

pavelsavara Feb 27, 2023

lewing Mar 5, 2023

lewing commented Mar 10, 2023 •

edited

Loading

kg Mar 10, 2023

radekdoulik Mar 10, 2023

radical Mar 10, 2023

radekdoulik Mar 10, 2023

radical commented Mar 10, 2023

azure-pipelines bot commented Mar 10, 2023

radical left a comment

lewing commented Mar 11, 2023

	<!-- warm up the cache -->
	<Exec Command="$(_EmBuilder) build MINIMAL" EnvironmentVariables="@(EmscriptenMinimalBuildEnvVars)" StandardOutputImportance="Low" StandardErrorImportance="Low" />

[wasm] Initial emscripten 3.1.30 support #81215

[wasm] Initial emscripten 3.1.30 support #81215

Conversation

radekdoulik commented Jan 26, 2023 • edited Loading

radekdoulik commented Jan 26, 2023

radekdoulik commented Feb 10, 2023

maraf commented Feb 13, 2023

radekdoulik commented Feb 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radekdoulik commented Feb 23, 2023 • edited Loading

lambdageek commented Feb 23, 2023

pavelsavara commented Feb 23, 2023

radekdoulik commented Feb 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lewing commented Mar 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radical commented Mar 10, 2023

azure-pipelines bot commented Mar 10, 2023

radical left a comment

Choose a reason for hiding this comment

lewing commented Mar 11, 2023

radekdoulik commented Jan 26, 2023 •

edited

Loading

radekdoulik commented Feb 21, 2023 •

edited

Loading

radekdoulik commented Feb 23, 2023 •

edited

Loading

lewing commented Mar 10, 2023 •

edited

Loading