-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[wasm] Initial emscripten 3.1.30 support (#81215)
* [wasm] Initial emscripten 3.1.30 support * Update icu dependency * Update emsdk dependency * Use new docker images * Add "icudt68_dat" as JS imported function. It's an undefined symbol in ICU, because we are not linking in a lib, that should in the end be linked out. Updated version of emscripten has by default turned on the LLD_REPORT_UNDEFINED . * Drop build-time support for undefined icudt68_dat. * Fix linker options Should be `--lto-O0` * Fix remaining conflict * Limit new warnings option to browser * Try to force reinstall of certifi * Unset `FROZEN_CACHE` for `embuilder build MINIMAL` * Update emsdk deps * Remove assert for stack address The linker puts stack at 0 sometime, so just check that the stack size is not zero. * Get back the stack base assert For non-wasm targets. Add comment. * Set stack size to 5MB Which was the default size in older emscripten versions. Let see if it is related to some of the issues. * Disable WBT tests with SkiSharp context: #82725 * Disable more WBT tests with SkiSharp * Set the stack size also in native targets * Update icu deps * Update emsdk deps * Enable BigInt support Co-authored-by: pavelsavara <[email protected]> * Enable BigInt here as well * Temporarily allow undefined symbols To unblock other work. After merge of main we are now again getting linker errors with: .nuget/packages/microsoft.netcore.runtime.icu.transport/8.0.0-preview.3.23128.1/runtimes/browser-wasm/native/lib/libicuuc.a(udata.ao): undefined symbol: icudt68_dat * Try to use pip-system-certs package Co-authored-by: Ankit Jain <[email protected]> * Fix merge damage for marking "icudt68_dat" a JS imported function + revert temporal fix. * Try another python certifi package * Try install pip-system-certs for emsdk's python * Try to update machine certs for www.sqlite.org * Refactor + upgrade pip Also use the newer pip-system-certs again * Use new net8 images * Add `-s INCOMING_MODULE_JS_API=print,printErr` * Introduce EmccStackSize msbuild property * Remove FIXME from merge We don't have afterUpdateGlobalBufferAndViews anymore * Fixes around updateMemoryViews * Pass --experimental-wasm-bigint to v8 Ubuntu 18.04 helix image has old v8 * Try multiple --engine-arg options * Revert "Introduce EmccStackSize msbuild property" This reverts commit f67ea5e. * Disable 3 filesystem related tests * Add bigint to AOT test template * Introduce EmccStackSize msbuild property * Update emsdk deps * Update icu deps * Revert "Add `-s INCOMING_MODULE_JS_API=print,printErr`" This reverts commit 889d036. * Update emsdk deps * Update icu deps * Disable one more file related test --------- Co-authored-by: Marek Fišera <[email protected]> Co-authored-by: pavelsavara <[email protected]> Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: Larry Ewing <[email protected]>
- Loading branch information
1 parent
8d9ca3f
commit fe95ddb
Showing
37 changed files
with
127 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,6 +201,6 @@ jobs: | |
|
||
# Browser WebAssembly windows | ||
- ${{ if in(parameters.platform, 'browser_wasm_win', 'wasi_wasm_win') }}: | ||
- (Windows.Amd64.Server2022.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2022-helix-webassembly | ||
- (Windows.Amd64.Server2022.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2022-helix-webassembly-net8 | ||
|
||
${{ insert }}: ${{ parameters.jobParameters }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,38 @@ | ||
# This seems to update the machine cert store so that python can download the files as required by emscripten's install | ||
# Based on info at https://pypi.org/project/certifi/ | ||
pip install certifi | ||
python -m pip install --upgrade pip | ||
pip install --upgrade certifi pip-system-certs | ||
|
||
$WebsiteURL="storage.googleapis.com" | ||
Try { | ||
$Conn = New-Object System.Net.Sockets.TcpClient($WebsiteURL,443) | ||
function UpdateSite { | ||
|
||
param ( | ||
$WebsiteURL | ||
) | ||
|
||
Try { | ||
$Stream = New-Object System.Net.Security.SslStream($Conn.GetStream()) | ||
$Stream.AuthenticateAsClient($WebsiteURL) | ||
$Conn = New-Object System.Net.Sockets.TcpClient($WebsiteURL,443) | ||
|
||
$Cert = $Stream.Get_RemoteCertificate() | ||
Try { | ||
$Stream = New-Object System.Net.Security.SslStream($Conn.GetStream()) | ||
$Stream.AuthenticateAsClient($WebsiteURL) | ||
|
||
$ValidTo = [datetime]::Parse($Cert.GetExpirationDatestring()) | ||
$Cert = $Stream.Get_RemoteCertificate() | ||
|
||
Write-Host "`nConnection Successful" -ForegroundColor DarkGreen | ||
Write-Host "Website: $WebsiteURL" | ||
} | ||
Catch { Throw $_ } | ||
Finally { $Conn.close() } | ||
} | ||
Catch { | ||
Write-Host "`nError occurred connecting to $($WebsiteURL)" -ForegroundColor Yellow | ||
$ValidTo = [datetime]::Parse($Cert.GetExpirationDatestring()) | ||
|
||
Write-Host "`nConnection Successful" -ForegroundColor DarkGreen | ||
Write-Host "Website: $WebsiteURL" | ||
Write-Host "Status:" $_.exception.innerexception.message -ForegroundColor Yellow | ||
Write-Host "" | ||
} | ||
Catch { Throw $_ } | ||
Finally { $Conn.close() } | ||
} | ||
Catch { | ||
Write-Host "`nError occurred connecting to $($WebsiteURL)" -ForegroundColor Yellow | ||
Write-Host "Website: $WebsiteURL" | ||
Write-Host "Status:" $_.exception.innerexception.message -ForegroundColor Yellow | ||
Write-Host "" | ||
} | ||
} | ||
|
||
UpdateSite("storage.googleapis.com") | ||
UpdateSite("www.sqlite.org") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.1.12 | ||
3.1.30 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.