-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] asset loading for workers #73484
Conversation
- split logging code into separate file `logging.ts` - add `dotnet.wasm` and `dotnet-crypto-worker.js` to mono-config.json - moved `readSymbolMapFile()` call to `startup.ts` - fixed bug in `setup_proxy_console()` which didn't really copy the original `log` and `error` functions of the console and caused recursion on error. - moved `init_crypto` after `mono_wasm_load_config` in `mono_wasm_pre_init_essential_async` - added new resource type `js-module-crypto` and `js-module-threads` - changed the detection of blazor startup sequence to not be disabled by presence of config, but only by config.assets having some assembly in it.
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # src/mono/wasm/runtime/crypto-worker.ts # src/mono/wasm/runtime/workers/dotnet-crypto-worker.js
Co-authored-by: Marek Fišera <[email protected]>
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Unfortunately the deadlock is still with us. Log |
You can run the tests a good bunch(30?) of times on helix, which can be done in one shot as we had discussed offline. It is helpful in finding similar issues. I wonder if we should always do that for tests that depend on workers, on CI. |
# Conflicts: # src/mono/wasm/runtime/debug.ts
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Pull request contains merge conflicts. |
# Conflicts: # src/mono/wasm/runtime/startup.ts
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
|
The wasm/debugger test failures are unrelated, and will be fixed by #73524 . |
We should queue up the crypto deadlock fix right after this. If this happens to cause any issue with crypto, then it can be fixed in that PR. |
assets.ts
logging.ts
dotnet.wasm
anddotnet-crypto-worker.js
to mono-config.json viaWasmAppBuilder
readSymbolMapFile()
call tostartup.ts
setup_proxy_console()
which didn't really copy the originallog
anderror
functions of the console and caused recursion on error.init_crypto
aftermono_wasm_load_config
inmono_wasm_pre_init_essential_async
js-module-crypto
andjs-module-threads
Most of this changes were moved from #73073 where is log of discussions about it
Together with dotnet/aspnetcore#43049