-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] just fix the crypto logging #73468
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailstesting crypto on CI
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
745b464
to
9843648
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Having an unhandled exception handler to log the trace, specifically for tests, would be very useful in debugging these random crashes. |
Can you add a description of the problem, and the fix, in the PR description? |
In old code: In the new code:
creates new object instance with the copy of references to incoming methods and we will not write to that instance after. In my other PR I moved all this code to |
And how did the bug show up in practice? |
in practice this will run infinite loop and crash the browser as Simon described here #72941 |
This only fixes wrong capture of originalConsole causing the crypto-worker to go to infinite loop when WS are not available.
This doesn't address the problem that forwarding logs to localhost WS in production is bad idea.
Contributes to #72941