Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redisable timouting MsQuic tests #69843

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented May 26, 2022

Contributes to #64944.

The test is still flaky and sometimes causes timeout for the entire test suite.

cc: @wfurt

@ghost
Copy link

ghost commented May 26, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #64944.

The test is still flaky and sometimes causes timeout for the entire test suite.

cc: @wfurt

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net.Quic

Milestone: -

@rzikm
Copy link
Member Author

rzikm commented May 26, 2022

The timeout occured in #69798

@wfurt
Copy link
Member

wfurt commented May 26, 2022

This seems to fail predictably for me as result of #69603 because we did not pull in new msquic for Windows.
With updated msquic (build locally from main) the test is passing fine.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think this is ok for now. We should update msquic and give it another try.

@rzikm
Copy link
Member Author

rzikm commented May 26, 2022

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr
Copy link
Member

I don't think this made it to the preview 5 branch which is seeing build failures on PR builds (for example here #69872). Should this change get cherry-picked to preview 5 branch?

@wfurt
Copy link
Member

wfurt commented May 26, 2022

I think that would be good @joperezr if #69603 did.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants