Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing MsQuic tests on Windows #69798

Merged
merged 2 commits into from
May 26, 2022

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented May 25, 2022

Contributes to #69792.

This PR disables newly failing tests. The failures seem to be confined to Windows 2022 Server.

@ghost
Copy link

ghost commented May 25, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #69792.

This PR disables newly failing tests. The failures seem to be confined to Windows 2022 Server.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net.Quic

Milestone: -

@rzikm rzikm requested a review from wfurt May 25, 2022 15:00
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented May 25, 2022

btw there are still Quic failures but it seems unrelated to this change.

   System.Net.Quic.Functional.Tests: [Long Running Test] 'System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate', Elapsed: 00:14:07
['System.Net.Quic.Functional.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@rzikm rzikm merged commit 5d3288d into dotnet:main May 26, 2022
@rzikm
Copy link
Member Author

rzikm commented May 26, 2022

btw there are still Quic failures but it seems unrelated to this change.

   System.Net.Quic.Functional.Tests: [Long Running Test] 'System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate', Elapsed: 00:14:07
['System.Net.Quic.Functional.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

I noticed, I will deal with that separately to unblock CI asap (this one is nondeterministic),

@joperezr
Copy link
Member

This is failing PR builds in 7.0-preview5 branch since they haven't been disabled there. Should this change make it there as well?

@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants