Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set SocketsHttpHandler's default connect timeout to 15s (#66607)" #68649

Merged
merged 1 commit into from
Apr 28, 2022
+2 −2
Merged

Revert "Set SocketsHttpHandler's default connect timeout to 15s (#66607)" #68649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Net/Http/HttpHandlerDefaults.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ internal static partial class HttpHandlerDefaults
public static readonly TimeSpan DefaultPooledConnectionLifetime = Timeout.InfiniteTimeSpan;
public static readonly TimeSpan DefaultPooledConnectionIdleTimeout = TimeSpan.FromMinutes(1);
public static readonly TimeSpan DefaultExpect100ContinueTimeout = TimeSpan.FromSeconds(1);
public static readonly TimeSpan DefaultConnectTimeout = TimeSpan.FromSeconds(15);
public static readonly TimeSpan DefaultConnectTimeout = Timeout.InfiniteTimeSpan;
}
}
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ public void ConnectTimeout_Default()
{
using (var handler = new SocketsHttpHandler())
{
Assert.Equal(TimeSpan.FromSeconds(15), handler.ConnectTimeout);
Assert.Equal(Timeout.InfiniteTimeSpan, handler.ConnectTimeout);
}
}

Expand Down