Revert "Set SocketsHttpHandler's default connect timeout to 15s (#66607)" #68649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 436b97c.
The change proved to be problematic as-is, because
There is a high chance that the user code has a retry logic that does retry when
SocketException
is caught but does not retry in case ofOperationCanceledException
. This can lead to a spike of (unretried) exceptions which weren't there before. Example:https://github.com/NuGet/NuGet.Client/blob/93bb3921490e9d499be1fb48d6cb9dcaff734db1/src/NuGet.Core/NuGet.Protocol/HttpSource/HttpRetryHandler.cs#L212-L263
The workaround with setting the
ConnectTimeout
back to infinity may not be available -- ifHttpClientHandler
is used instead ofSocketsHttpHandler
(e.g. due to reusing code between .NET Framework and .NET Core/.NET 5+), or if the code that executes the requests is hidden inside a library.I will reopen #66297 for further considerations.