[main] Update dependencies from dotnet/linker #66538
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…311.3 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22161.3
…314.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22164.1
|
@vitek-karas is this is an expected error now after dotnet/linker#2681?
|
|
Yes - sorry, I didn't realize this would happen (otherwise I would have preemptively fixed these). There are actually several issues here, all around Type.BaseType used in a loop. Linker doesn't perform data flow over backward branches (loops), while the analyzer does. The newest analyzer now tries to propagate annotations over the BaseType and because of the better data flow, it leads to warnings. I will work on fixing these... /cc @sbomer |
In the case of Type.Helpers.cs better data flow analysis in the analyzer uncovers a warning. The method is used to implement reflection functionality and the warnings are not a problem and should be suppressed. In the case of the System.Private.Xml Types.cs, the analyzer shows a real issue where the annotation is not enough for what the method does. This changed the annotation to All - which is already in place in all the callers anyway.
|
I pushed some fixes @vitek-karas made for the legitimate warnings. We are waiting for dependency flow of dotnet/linker#2694 which fixes the other issue (with these two I get a clean build locally). Dependency flow seems to be blocked by https://github.com/dotnet/core-eng/issues/15812. |
…318.5 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22168.5
…318.6 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22168.6
|
@sbomer looks like we got a dependency flow that includes dotnet/linker#2694 but there are still some linker errors in the build. |
dotnet-maestro
bot
deleted the
darc-main-04467fa1-d7d2-45fa-98e8-08272e61ecf7
branch
* Update dependencies from https://github.com/dotnet/linker build 20220311.3 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22161.3 * Update dependencies from https://github.com/dotnet/linker build 20220314.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22164.1 * Fix warnings introduced by new version of trim analyzer In the case of Type.Helpers.cs better data flow analysis in the analyzer uncovers a warning. The method is used to implement reflection functionality and the warnings are not a problem and should be suppressed. In the case of the System.Private.Xml Types.cs, the analyzer shows a real issue where the annotation is not enough for what the method does. This changed the annotation to All - which is already in place in all the callers anyway. * Update dependencies from https://github.com/dotnet/linker build 20220318.5 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22168.5 * Update dependencies from https://github.com/dotnet/linker build 20220318.6 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22168.6 * Fix suppression for MakeGenericType of Nullable Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: vitek-karas <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
This pull request updates the following dependencies
From https://github.com/dotnet/linker