Fix empty/null handling for Type.BaseType intrinsic #2694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vitek-karas this should fix some of the issues you are seeing with dataflow in foreach loops involving
Type.BaseType
.@vitek-karas shared the following testcase which was warning:
This was producing a warning because during the first pass of the analysis over
t.BaseType
, the analyzer hadn't yet figured out thatt
had annotationAll
. (The reason for this has to do with exception handling - the statement is reachable only through a finally block which we hadn't visited yet).BaseType
gave backNone
, which produced a warning on the call toGetProperties
.What this indicates to me is that dotnet/runtime#106886 is important not just to be precise about the warning behavior when there are empty inputs, but also for the correctness of the solver.