Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Remove some of the restrictions on constrained calls from #59182

Merged
merged 2 commits into from
Sep 17, 2021
Merged

[mono] Remove some of the restrictions on constrained calls from #59182

merged 2 commits into from
Sep 17, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 15, 2021

gsharedvt methods.

Fixes #58204.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@vargaz vargaz force-pushed the gsharedvt-constrained branch from 0f934e8 to ecce350 Compare September 16, 2021 10:56
lambdageek
lambdageek previously approved these changes Sep 17, 2021
View reviewed changes
@lambdageek lambdageek mentioned this pull request Sep 17, 2021
Closed
@lambdageek
Copy link
Member

@vargaz Could you also remove the [ActiveIssue] from the tests in #58276

@lambdageek lambdageek dismissed their stale review September 17, 2021 02:56

let's run again with the libraries tests re-enabled

@vargaz
Copy link
Contributor Author

vargaz commented Sep 17, 2021

Reenabled, is CI actually testing these configurations ?

@lambdageek
Copy link
Member

Reenabled, is CI actually testing these configurations ?

Think so. @akoeplinger are they disabled somewhere else for another reason?

@lewing
Copy link
Member

lewing commented Sep 17, 2021

they are disabled in src/libraries/tests.proj

@lambdageek lambdageek mentioned this pull request Sep 17, 2021
Open
@vargaz vargaz merged commit 23a8a62 into dotnet:main Sep 17, 2021
@vargaz vargaz deleted the gsharedvt-constrained branch September 17, 2021 19:29
@srxqds
Copy link
Contributor

srxqds commented Sep 17, 2021

I am sorry to ask again for backporting to 6.0? because the 6.0 is a LTS release, hope bug fixes can be merged more and more.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@akoeplinger
Copy link
Member

To close the loop in this, we decided to hold off backporting this to 6.0 for now: #58204 (comment)

If you see an issue in a real project (not just constructed tests) then please file a new issue and we'll reconsider.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@imhameed imhameed Awaiting requested review from imhameed

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees
No one assigned
Labels
area-Codegen-AOT-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attempting to JIT compile method in System.Text.Json tests on iOS devices
5 participants
@vargaz @lambdageek @lewing @srxqds @akoeplinger