-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip System.Text.Json tests on iOS/tvOS that don't work #58276
Conversation
A number of tests using `dynamic` can't work on iOS devices due to System.Reflection.Emit not being supported, added PlatformDetection checks for those. A few other tests run into an "Attempting to JIT compile method" issue that is tracked by dotnet#58204
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsA number of tests using A few other tests run into an "Attempting to JIT compile method" issue that is tracked by #58204
|
does this mean there are missing |
I don't know an easy way to attach |
nit2: wrong again. They really do use |
...libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/NumberHandlingTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although please change the ConvertJSONArrayToIListOfJsonNode
test to not use dynamic and remove the [ConditionalFact]
from the test.
A number of tests using
dynamic
can't work on iOS devices due to "dynamic invoke" (where Mono does an indirect runtime invoke using a single universal invoke wrapper) not being supported, added PlatformDetection checks for System.Reflection.Emit since that is a close enough approximation for those.A few other tests run into an "Attempting to JIT compile method" issue that is tracked by #58204