System.Net.Ping: Skip TimeoutIsRespected test if network is unreachable #58745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestSettings.UnreachableAddress is using 192.0.2.0 which is documented in RFC5735 as a network to be used in docs/example code. On the Android devices in Helix the upstream network is configured to not route this address which results in a "Destination Net Unreachable" response which causes the timeout argument to ping to be ignored and ping returns immediately. Skip the test in these cases. Example output from ping on the device: ``` 1|sunfish:/ $ time ping -c 1 -W 2 -s 50 192.0.2.0 PING 192.0.2.0 (192.0.2.0) 50(78) bytes of data. From 131.107.5.118: icmp_seq=1 Destination Net Unreachable --- 192.0.2.0 ping statistics --- 1 packets transmitted, 0 received, +1 errors, 100% packet loss, time Oms 0m00.03s real 0m00.00s user 0m00.00s system ```
stephentoub
reviewed
Sep 7, 2021
| bool destinationNetUnreachable = false; | ||
| p.OutputDataReceived += delegate (object sendingProcess, DataReceivedEventArgs outputLine) | ||
| { | ||
| if (outputLine.Data?.Contains("Destination Net Unreachable", StringComparison.OrdinalIgnoreCase) == true) |
There was a problem hiding this comment.
Does this text get localized on any OSes?
There was a problem hiding this comment.
On Windows it is, but this file is specific to Unix where I haven't seen this output being localized.
We also already rely on the English strings in ParseReturnedPacketSize and ParseNumPingsSent.
There was a problem hiding this comment.
Suggested change
| if (outputLine.Data?.Contains("Destination Net Unreachable", StringComparison.OrdinalIgnoreCase) == true) | |
| if (outputLine.Data?.Contains("Destination Net Unreachable", StringComparison.OrdinalIgnoreCase)) |
maybe we should have an analyzer for == true and != false
There was a problem hiding this comment.
@danmoseley this doesn't work because of the null conditional operator so we need the explicit comparison.
steveisok
approved these changes
Sep 8, 2021
akoeplinger
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 9, 2021
…le (dotnet#58745) The TestSettings.UnreachableAddress is using 192.0.2.0 which is documented in RFC5735 as a network to be used in docs/example code. On the Android devices in Helix the upstream network is configured to not route this address which results in a "Destination Net Unreachable" response which causes the timeout argument to ping to be ignored and ping returns immediately. Skip the test in these cases. Example output from ping on the device: ``` 1|sunfish:/ $ time ping -c 1 -W 2 -s 50 192.0.2.0 PING 192.0.2.0 (192.0.2.0) 50(78) bytes of data. From 131.107.5.118: icmp_seq=1 Destination Net Unreachable --- 192.0.2.0 ping statistics --- 1 packets transmitted, 0 received, +1 errors, 100% packet loss, time Oms 0m00.03s real 0m00.00s user 0m00.00s system ``` (cherry picked from commit 84fb871)
steveisok
pushed a commit
that referenced
this pull request
Sep 13, 2021
…t and test fixes for Android (#58841) Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0 Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally. This PR looks to reduce the failures on CI by skipping the problematic suites Skips test suites logged in #53624 ActiveIssues #58440 #58418 #58367 #58584 Co-authored-by: Mitchell Hwang <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: Jo Shields <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestSettings.UnreachableAddressis using192.0.2.0(TEST-NET-1) which is documented in RFC5735 as a network to be used in docs/example code.On the Android devices in Helix the upstream network is configured to not route this address which results in a
Destination Net Unreachableresponse which causes the timeout argument to ping to be ignored and ping returns immediately.Skip the test in these cases.
Example output from ping on the device: