Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libraries][MacCatalyst] System.IO.FileSystem.Watcher NonZeroTimeout_NoActivity_TimesOut failure #58418

Open
mdh1418 opened this issue Aug 31, 2021 · 7 comments
Open

[libraries][MacCatalyst] System.IO.FileSystem.Watcher NonZeroTimeout_NoActivity_TimesOut failure #58418

mdh1418 opened this issue Aug 31, 2021 · 7 comments
Labels
area-System.IO needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration test-bug Problem in test source code (most likely)
Milestone
Future

Comments

@mdh1418
Copy link
Member

mdh1418 commented Aug 31, 2021 

System.IO.Tests.WaitForChangedTests.NonZeroTimeout_NoActivity_TimesOut(changeType: Created, enabledBeforeWait: True)
    Assert.Equal() Failure\nExpected: 0\nActual:   1

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1329092&view=logs&j=3a31f037-b056-5f1b-7dc0-d7edb248100e&t=6f68142f-0a7c-54ea-feaf-6db573804c2c
@mdh1418 mdh1418 added this to the 7.0.0 milestone Aug 31, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Aug 31, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details 
System.IO.Tests.WaitForChangedTests.NonZeroTimeout_NoActivity_TimesOut(changeType: Created, enabledBeforeWait: True)
    Assert.Equal() Failure\nExpected: 0\nActual:   1

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1329092&view=logs&j=3a31f037-b056-5f1b-7dc0-d7edb248100e&t=6f68142f-0a7c-54ea-feaf-6db573804c2c

Author: mdh1418
Assignees: -
Labels:

area-System.IO, untriaged
Milestone: 7.0.0

@adamsitnik
Copy link
Member

cc @jozkee

@adamsitnik adamsitnik added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration test-bug Problem in test source code (most likely) and removed untriaged New issue has not been triaged by the area owner labels Aug 31, 2021
@mdh1418 mdh1418 mentioned this issue Aug 31, 2021
Merged
@akoeplinger
Copy link
Member

Looks like this only fails on MacCatalyst arm64, but not x64.

@adamsitnik
Copy link
Member

Looks like this only fails on MacCatalyst arm64, but not x64.

@akoeplinger does it mean that we would need macbook M1 to repro it?

@akoeplinger
Copy link
Member

Yes.

@mdh1418 mdh1418 mentioned this issue Sep 8, 2021
Merged
steveisok pushed a commit that referenced this issue Sep 13, 2021
@mdh1418 @akoeplinger @directhex
[release/6.0] Skip test suites crashing on CI for iOS/tvOS/MacCatalys…
3e3fd87 
…t and test fixes for Android (#58841)

Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0

Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally.

This PR looks to reduce the failures on CI by skipping the problematic suites
Skips test suites logged in #53624

ActiveIssues
#58440
#58418
#58367
#58584

Co-authored-by: Mitchell Hwang <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Jo Shields <[email protected]>
@danmoseley
Copy link
Member

Again in #66992

System.IO.Tests.WaitForChangedTests.NonZeroTimeout_NoActivity_TimesOut [Details] [History] [Artifacts]
Data Driven SubResults
❌ System.IO.Tests.WaitForChangedTests.NonZeroTimeout_NoActivity_TimesOut
Exception Message
Assert.Equal() Failure
Expected: 0
Actual: 1
Pass Rate
Test has failed 5 out of 33591 runs (0.01%)
Failing Configuration
net7.0-OSX-Debug-x64-CoreCLR_checked-OSX.1200.Amd64.Open

@danmoseley
Copy link
Member

It's odd as it seems just a getter/setter validation.

runtime/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs

Lines 121 to 123 in baffb71

if (enabledBeforeWait) fsw.EnableRaisingEvents = true;
AssertTimedOut(fsw.WaitForChanged(changeType, 1));
Assert.Equal(enabledBeforeWait, fsw.EnableRaisingEvents);

@danmoseley danmoseley mentioned this issue Apr 20, 2022
Merged
@jeffhandley jeffhandley modified the milestones: 7.0.0, Future Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.IO needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@jeffhandley @akoeplinger @adamsitnik @danmoseley @mdh1418