-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[mono] Fix a few corner case overflow operations" #57501
Conversation
This reverts commit e81efc8.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@lewing @lambdageek - can you approve this -- Vlad's original PR exposed a wasm issue |
Hello @lambdageek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the emscripten bug we are hitting?
Vlad has more details, and he was going to send email. He is on vacation this week, so possibly not going to happen until next week. |
Both in that PR and in parts of mono we rely on some undefined behavior when converting float to int. On wasm that undefined behavior resulted in some counter intuitive side effects, which turns out are allowed to happen. I will just refactor the code instead, so we don't run into undefined behavior at all in the first place. |
Reverts #57407