Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[mono] Fix a few corner case overflow operations" #57501

Merged
1 commit merged into from
Aug 16, 2021

Conversation

SamMonoRT
Copy link
Member

Reverts #57407

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@SamMonoRT
Copy link
Member Author

@lewing @lambdageek - can you approve this -- Vlad's original PR exposed a wasm issue

@ghost
Copy link

ghost commented Aug 16, 2021

Hello @lambdageek!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the emscripten bug we are hitting?

@SamMonoRT
Copy link
Member Author

What is the emscripten bug we are hitting?

Vlad has more details, and he was going to send email. He is on vacation this week, so possibly not going to happen until next week.

@BrzVlad
Copy link
Member

BrzVlad commented Aug 18, 2021

Both in that PR and in parts of mono we rely on some undefined behavior when converting float to int. On wasm that undefined behavior resulted in some counter intuitive side effects, which turns out are allowed to happen. I will just refactor the code instead, so we don't run into undefined behavior at all in the first place.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants