-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests for overflow checking operations are disabled on Mono #51323
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
@naricc - please take a look |
@BrzVlad - please take a look at this one too |
PR to revert the change is #57501. We need to discuss the wasm failures (seemingly exposed by this PR, but not caused by the changes). |
Moving to milestone 7.0, it is unlikely we get in the right fix prior to cutoff. Based on changes we may consider backporting it. |
1)
JIT/Directed/Convert/value_numbering_checked_casts_of_constants.csproj
- #51440 introduced a new test which has been disabled on Mono. This issue will track re-enabling it once the root cause has been investigated and fixed. See #50450 (comment) for the context on the failure modes.2)
JIT/Directed/Convert/signed_overflow_conversions_are_not_treated_as_unsigned.ilproj
- failed in CI when it was introduced, also on many configurations (Browser (interpreter) & LLVM AOT). I assume it has the same underlying cause as the above failure.Note: at least part of this failure on interpreter is because of the fundamental disagreement on the interpretation of some IL sequences between RyuJit & Mono interpreter. See #53189, #53189 (comment).<- this has been fixed, but it is unknown if the test above still fails.3)
JIT/Methodical/int64/misc/longmul.ilproj
- failed on llvmaot Linux arm64/x64, minijit Linux arm64/OSX x64, monointerpreter Linux arm64 / OSX x64.4)
JIT/Methodical/Overflow/FloatOvfToInt2
family of tests - failed on llvmaot Linux x64 and arm64.The text was updated successfully, but these errors were encountered: