Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests for overflow checking operations are disabled on Mono #51323

Closed
SingleAccretion opened this issue Apr 15, 2021 · 5 comments · Fixed by #57407 or #58114
Closed

Some tests for overflow checking operations are disabled on Mono #51323

SingleAccretion opened this issue Apr 15, 2021 · 5 comments · Fixed by #57407 or #58114
Assignees
Labels
area-Codegen-JIT-mono disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime
Milestone

Comments

@SingleAccretion
Copy link
Contributor

SingleAccretion commented Apr 15, 2021

1) JIT/Directed/Convert/value_numbering_checked_casts_of_constants.csproj - #51440 introduced a new test which has been disabled on Mono. This issue will track re-enabling it once the root cause has been investigated and fixed. See #50450 (comment) for the context on the failure modes.

2) JIT/Directed/Convert/signed_overflow_conversions_are_not_treated_as_unsigned.ilproj - failed in CI when it was introduced, also on many configurations (Browser (interpreter) & LLVM AOT). I assume it has the same underlying cause as the above failure.

Note: at least part of this failure on interpreter is because of the fundamental disagreement on the interpretation of some IL sequences between RyuJit & Mono interpreter. See #53189, #53189 (comment). <- this has been fixed, but it is unknown if the test above still fails.

3) JIT/Methodical/int64/misc/longmul.ilproj - failed on llvmaot Linux arm64/x64, minijit Linux arm64/OSX x64, monointerpreter Linux arm64 / OSX x64.

4) JIT/Methodical/Overflow/FloatOvfToInt2 family of tests - failed on llvmaot Linux x64 and arm64.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 15, 2021
@BruceForstall BruceForstall added disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime labels Apr 16, 2021
@SingleAccretion SingleAccretion changed the title JIT/Directed/Convert/value_numbering_checked_casts_of_constants test disabled on Mono Some tests for overflow checking operations are disabled on Mono May 24, 2021
@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Jun 24, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 24, 2021
@SamMonoRT
Copy link
Member

@naricc - please take a look

@SamMonoRT
Copy link
Member

@BrzVlad - please take a look at this one too

@SamMonoRT SamMonoRT assigned BrzVlad and unassigned naricc Aug 11, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 14, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 16, 2021
@SamMonoRT SamMonoRT reopened this Aug 16, 2021
@SamMonoRT
Copy link
Member

PR to revert the change is #57501. We need to discuss the wasm failures (seemingly exposed by this PR, but not caused by the changes).

@SamMonoRT
Copy link
Member

Moving to milestone 7.0, it is unlikely we get in the right fix prior to cutoff. Based on changes we may consider backporting it.

@SamMonoRT SamMonoRT modified the milestones: 6.0.0, 7.0.0 Aug 16, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 25, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-JIT-mono disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime
Projects
None yet
6 participants