Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Add wrapper info for native func wrappers. #55602

Merged
merged 1 commit into from
Jul 14, 2021
Merged

[mono] Add wrapper info for native func wrappers. #55602

merged 1 commit into from
Jul 14, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jul 13, 2021

Fixes #55567.

@ghost
Copy link

ghost commented Jul 13, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #55567.

Author: vargaz
Assignees: -
Labels:

area-VM-meta-mono
Milestone: -

lambdageek
lambdageek reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you also need to delete:

mono_marshal_set_wrapper_info (res, NULL);

on line 3485?

@vargaz
Copy link
Contributor Author

vargaz commented Jul 14, 2021 •
edited
Loading

Failures are relevant:

0x7fff72b08f5a - /usr/lib/system/libsystem_platform.dylib : _sigtramp
      0x1011058e3 - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : monoeg_malloc
      0x1010f46b5 - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : interp_transform_call
      0x1010da25e - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : generate_code
      0x1010ece15 - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : generate
      0x1010ec8c7 - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : mono_interp_transform_method
      0x1010ba87f - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : interp_create_method_pointer
      0x100fad338 - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : jit_compile_method_with_opt
      0x100fad11a - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : mono_jit_compile_method
      0x100ea654e - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : mono_ftnptr_to_delegate_impl
      0x100e94630 - /tmp/helix/working/C5480A78/p/libcoreclr.dylib : ves_icall_System_Runtime_InteropServices_Marshal_GetDelegateForFunctionPointerInternal_raw

@vargaz vargaz requested a review from BrzVlad as a code owner July 14, 2021 06:13
@vargaz vargaz merged commit 01ce681 into dotnet:main Jul 14, 2021
@vargaz vargaz deleted the native-func-wrapper branch July 14, 2021 09:07
thaystg added a commit to thaystg/runtime that referenced this pull request Jul 14, 2021
@thaystg
Merge branch 'main' of github.com:thaystg/runtime into thays_support_…
a8fb8cf 
…debugger_custom_views

* 'main' of github.com:thaystg/runtime: (125 commits)
  [wasm] [debugger] Support method calls  (dotnet#55458)
  [debugger] Fix debugging after hot reloading (dotnet#55599)
  Inliner: Extend IL limit for profiled call-sites, allow inlining for switches. (dotnet#55478)
  DiagnosticSourceEventSource supports base class properties (dotnet#55613)
  [mono] Fix race during mono_image_storage_open (dotnet#55201)
  [mono] Add wrapper info for native func wrappers. (dotnet#55602)
  H/3 and Quic AppContext switch (dotnet#55332)
  Compression.ZipFile support for Unix Permissions (dotnet#55531)
  [mono] Fix skipping of static methods during IMT table construction. (dotnet#55610)
  Combine System.Private.Xml TrimmingTests projects (dotnet#55606)
  fix name conflict with Configuration class (dotnet#55597)
  Finish migrating RSAOpenSsl from RSA* to EVP_PKEY*
  Disable generic math (dotnet#55540)
  Obsolete CryptoConfig.EncodeOID (dotnet#55592)
  Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp (dotnet#54995)
  Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled (dotnet#55572)
  Fix Task.WhenAny failure mode when passed ICollection of zero tasks (dotnet#55580)
  Consume DistributedContextPropagator in DiagnosticsHandler (dotnet#55392)
  Add property ordering feature (dotnet#55586)
  Reduce subtest count in Reflection (dotnet#55537)
  ...
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@imhameed imhameed Awaiting requested review from imhameed

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

Assignees
No one assigned
Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android AOT crashes at runtime
2 participants
@vargaz @lambdageek