[wasm] Build static components; include hot_reload in runtime #54568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWorkaround until #54565 is fixed
|
|
/cc @lateralusX |
lambdageek
commented
Jun 22, 2021
|
This also needs to go into .NET 6 Preview 6 |
|
Does this enable, or fix something? |
Yea it fixes hot reload on .NET 6 P6 |
Is there a test that we can enable with this, so we get validation too? |
Workaround until dotnet#54565 is fixed Build the runtime always with support for hot_reload, and without diagnostics_tracing
lambdageek
force-pushed
the
fix-wasm-hot_reload-component
branch
from
b243253
to
be8a1e8
Compare
Just check that the capabilities are non-empty which is a good proxy for hot reload being enabled in the runtime.
lambdageek
force-pushed
the
fix-wasm-hot_reload-component
branch
from
74ad995
to
5da0bde
Compare
|
@radical I added a new functional test for the browser. didn't try very hard to override all the build lane stuff, but at least for a default |
|
wasm failure is #53957 |
radical
reviewed
Jun 23, 2021
radical
reviewed
Jun 23, 2021
lambdageek
force-pushed
the
fix-wasm-hot_reload-component
branch
from
303e48e
to
5a084cf
Compare
radical
approved these changes
Jun 23, 2021
...ssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj
Outdated
Show resolved
Hide resolved
| Condition="'$(TargetOS)' == 'Browser'"> | ||
| <ItemGroup> | ||
| <!-- FIXME: this belongs in eng/testing/tests.wasm.targets --> | ||
| <!-- FIXME: Can we do something on the Content items in the referenced projects themselves to get this for free? --> |
...ests/FunctionalTests/WebAssembly/Browser/HotReload/WebAssembly.Browser.HotReload.Test.csproj
Show resolved
Hide resolved
src/tests/FunctionalTests/WebAssembly/Browser/HotReload/Program.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/6.0-preview6 |
|
Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/965256876 |
steveisok
pushed a commit
that referenced
this pull request
Jun 24, 2021
…load in runtime (#54622) Backport of #54568 to release/6.0-preview6 Workaround until #54565 is fixed Build the runtime always with support for hot_reload, and without diagnostics_tracing Co-authored-by: Aleksey Kliger <[email protected]> Co-authored-by: Thays Grazia <[email protected]>
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jun 24, 2021
…bugger2 * origin/main: (107 commits) Disable MacCatalyst arm64 PR test runs on staging pipeline (dotnet#54678) [WASM] Fix async/await in config loading (dotnet#54652) Fix for heap_use_after_free flagged by sanitizer (dotnet#54679) [wasm] Bump emscripten to 2.0.23 (dotnet#53603) Fix compiler references when building inside VS (dotnet#54614) process more TLS frames at one when available (dotnet#50815) Add PeriodicTimer (dotnet#53899) UdpClient with span support (dotnet#53429) exclude fragile tests (dotnet#54671) get last error before calling a method that might fail as well (dotnet#54667) [FileStream] add tests for device and UNC paths (dotnet#54545) Fix sporadic double fd close (dotnet#54660) Remove Version.Clone from AssemblyName.Clone (dotnet#54621) [wasm] Enable fixed libraries tests (dotnet#54641) [wasm] Fix blazor/aot builds (dotnet#54651) [mono][wasm] Fix compilation error on wasm (dotnet#54659) Fix telemetry for Socket connects to Dns endpoints (dotnet#54071) [wasm] Build static components; include hot_reload in runtime (dotnet#54568) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) ...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround until #54565 is fixed
Build the runtime always with support for hot_reload, and without diagnostics_tracing