Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect_DualMode_DnsConnect_RetrievedEndPoints_Success - Assert ::1 #54677

Closed
karelz opened this issue Jun 24, 2021 · 8 comments · Fixed by #54681
Closed

Connect_DualMode_DnsConnect_RetrievedEndPoints_Success - Assert ::1 #54677

karelz opened this issue Jun 24, 2021 · 8 comments · Fixed by #54681
Assignees
@antonfirsov
Labels
area-System.Net.Sockets disabled-test The test is disabled in source code against the issue os-linux Linux OS (any supported distro) test-run-core Test failures in .NET Core test runs
Milestone
6.0.0

Comments

@karelz
Copy link
Member

karelz commented Jun 24, 2021 •
edited
Loading

Affected test namespaces:

  • System.Net.Sockets.Tests.ConnectTask
  • System.Net.Sockets.Tests.ConnectCancellableTask
  • System.Net.Sockets.Tests.ConnectSync
  • System.Net.Sockets.Tests.ConnectSyncForceNonBlocking
  • System.Net.Sockets.Tests.ConnectApm
  • System.Net.Sockets.Tests.ConnectEap
    System.Net.Sockets.Tests.ConnectCancellableTask.Connect_DualMode_DnsConnect_RetrievedEndPoints_Success [FAIL]
      Assert.Equal() Failure
      Expected: ::ffff:127.0.0.1
      Actual:   ::1
      Stack Trace:
        /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs(132,0): at System.Net.Sockets.Tests.Connect`1.Connect_DualMode_DnsConnect_RetrievedEndPoints_Success()
        --- End of stack trace from previous location ---

Test failures 3/12-6/23 (incl. PRs):

Date Run OS Flavor Namespace
6/6 Official run SLES.12.Amd64.Open Mono ConnectSync
6/6 Official run RedHat.7.Amd64.Open CoreCLR ConnectEap
6/7 PR #53837 Debian.10.Amd64.Open Mono ConnectCancellableTask
6/8 Official run SLES.12.Amd64.Open Mono ConnectCancellableTask
6/8 PR #53808 Alpine.312.Amd64.Open CoreCLR ConnectTask
6/8 PR #53869 Fedora.30.Amd64.Open Mono ConnectEap
6/8 PR #53206 SLES.15.Amd64.Open CoreCLR ConnectCancellableTask
6/9 Official run Fedora.30.Amd64.Open CoreCLR ConnectApm
6/10 PR #53968 Ubuntu.1804.ArmArch.Open Mono ConnectTask
6/10 PR #53972 Centos.8.Amd64.Open Mono ConnectSyncForceNonBlocking
6/10 PR #53984 SLES.15.Amd64.Open CoreCLR ConnectCancellableTask
6/11 PR #53982 Centos.8.Amd64.Open CoreCLR ConnectApm
6/11 Official run Debian.9.Amd64.Open Mono ConnectApm
6/13 PR #54094 Debian.10.Amd64.Open Mono ConnectApm
6/14 PR #54133 Ubuntu.1804.ArmArch.Open Mono ConnectSyncForceNonBlocking
6/14 Official run Ubuntu.1910.Amd64.Open CoreCLR ConnectCancellableTask
6/14 PR #54099 Centos.8.Amd64.Open Mono ConnectSync
6/14 PR #53606 Debian.10.Amd64.Open CoreCLR ConnectCancellableTask
6/16 PR #54250 Debian.10.Amd64.Open Mono ConnectTask
6/16 PR #54245 Fedora.30.Amd64.Open CoreCLR ConnectSync
6/16 PR #54245 Fedora.30.Amd64.Open CoreCLR ConnectTask
6/17 PR #54040 SLES.15.Amd64.Open Mono ConnectTask
6/18 PR #53450 Debian.10.Amd64.Open Mono ConnectSync
6/18 PR #54305 Fedora.30.Amd64.Open CoreCLR ConnectTask
6/18 Official run Fedora.30.Amd64.Open CoreCLR ConnectSync
6/18 PR #53450 SLES.15.Amd64.Open Mono ConnectSync
6/18 PR #54281 Debian.9.Amd64.Open Mono ConnectTask
6/18 PR #54246 SLES.15.Amd64.Open Mono ConnectTask
6/19 PR #54207 Centos.8.Amd64.Open Mono ConnectSync
6/19 PR #54261 Debian.9.Amd64.Open Mono ConnectApm
6/20 PR #54451 Debian.9.Amd64.Open Mono ConnectCancellableTask
6/21 PR #54477 Debian.10.Amd64.Open Mono ConnectSync
6/21 PR #54246 SLES.15.Amd64.Open CoreCLR ConnectSyncForceNonBlocking
6/21 PR #54218 Debian.10.Amd64.Open Mono ConnectCancellableTask
6/21 PR #54136 Debian.10.Amd64.Open Mono ConnectCancellableTask
6/22 Official run Debian.10.Amd64.Open Mono ConnectSync
6/22 PR #54253 Alpine.312.Amd64.Open CoreCLR ConnectTask
6/22 PR #49737 Fedora.30.Amd64.Open Mono ConnectTask
6/22 PR #54511 Debian.10.Amd64.Open CoreCLR ConnectSync
6/22 PR #54578 Fedora.30.Amd64.Open Mono ConnectTask
6/23 PR #54518 Debian.10.Amd64.Open CoreCLR ConnectApm
6/23 PR #54253 Fedora.30.Amd64.Open Mono ConnectSync
6/23 PR #54595 SLES.15.Amd64.Open Mono ConnectEap
6/23 Official run Centos.8.Amd64.Open Mono ConnectCancellableTask
6/23 PR #54544 SLES.15.Amd64.Open CoreCLR ConnectTask
6/23 PR #54568 Fedora.30.Amd64.Open Mono ConnectEap
6/23 PR #54053 SLES.15.Amd64.Open CoreCLR ConnectCancellableTask
6/23 PR #54621 Fedora.30.Amd64.Open CoreCLR ConnectCancellableTask
6/23 PR #54625 Centos.8.Amd64.Open CoreCLR ConnectEap
6/24 1x PR -- -- --
6/26 2x Official run + 1x PR -- -- --
6/27 3x PR -- -- --
6/28 6x PR -- -- --
6/29 3x PR -- -- Attempt for fix in PR #54681
6/30 5x PR -- -- --
7/1 3x PR -- -- --
7/2 1x PR -- -- --
7/7 2x PR -- -- --
7/8 4x PR -- -- --
7/9 1x PR -- -- --
7/10 Official run Centos.8.Amd64.Open Mono ConnectTask
7/10 Official run SLES.15.Amd64.Open CoreCLR ConnectTask
7/10 PR #53151 Debian.10.Amd64.Open Mono ConnectApm
7/13 Official run Fedora.32.Amd64.Open Mono ConnectTask
7/14 PR #52699 Alpine.312.Amd64.Open CoreCLR ConnectCancellableTask
7/15 PR #55772 Centos.8.Amd64.Open CoreCLR ConnectCancellableTask
7/16 PR #55787 Debian.9.Amd64.Open Mono ConnectEap
7/16 PR #55856 Centos.8.Amd64.Open Mono ConnectTask
7/16 PR #55857 SLES.15.Amd64.Open Mono ConnectCancellableTask
7/18 PR #55882 RedHat.7.Amd64.Open Mono ConnectCancellableTask
7/18 PR #55857 Fedora.32.Amd64.Open Mono ConnectApm
@karelz karelz added area-System.Net.Sockets test-run-core Test failures in .NET Core test runs labels Jun 24, 2021
@karelz karelz added this to the 6.0.0 milestone Jun 24, 2021
@ghost
Copy link

ghost commented Jun 24, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Affected test namespaces:

  • System.Net.Sockets.Tests.ConnectTask
  • System.Net.Sockets.Tests.ConnectCancellableTask
  • System.Net.Sockets.Tests.ConnectSync
  • System.Net.Sockets.Tests.ConnectSyncForceNonBlocking
  • System.Net.Sockets.Tests.ConnectApm
  • System.Net.Sockets.Tests.ConnectEap
    System.Net.Sockets.Tests.ConnectCancellableTask.Connect_DualMode_DnsConnect_RetrievedEndPoints_Success [FAIL]
      Assert.Equal() Failure
      Expected: ::ffff:127.0.0.1
      Actual:   ::1
      Stack Trace:
        /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs(132,0): at System.Net.Sockets.Tests.Connect`1.Connect_DualMode_DnsConnect_RetrievedEndPoints_Success()
        --- End of stack trace from previous location ---
Date Run OS Flavor Namespace
6/6 Official run SLES.12.Amd64.Open Mono ConnectSync
6/6 Official run RedHat.7.Amd64.Open CoreCLR ConnectEap
6/7 PR #53837 Debian.10.Amd64.Open Mono ConnectCancellableTask
6/8 Official run SLES.12.Amd64.Open Mono ConnectCancellableTask
6/8 PR #53808 Alpine.312.Amd64.Open CoreCLR ConnectTask
6/8 PR #53869 Fedora.30.Amd64.Open Mono ConnectEap
6/8 PR #53206 SLES.15.Amd64.Open CoreCLR ConnectCancellableTask
6/9 Official run Fedora.30.Amd64.Open CoreCLR ConnectApm
6/10 PR #53968 Ubuntu.1804.ArmArch.Open Mono ConnectTask
6/10 PR #53972 Centos.8.Amd64.Open Mono ConnectSyncForceNonBlocking
6/10 PR #53984 SLES.15.Amd64.Open CoreCLR ConnectCancellableTask
6/11 PR #53982 Centos.8.Amd64.Open CoreCLR ConnectApm
6/11 Official run Debian.9.Amd64.Open Mono ConnectApm
6/13 PR #54094 Debian.10.Amd64.Open Mono ConnectApm
6/14 PR #54133 Ubuntu.1804.ArmArch.Open Mono ConnectSyncForceNonBlocking
6/14 Official run Ubuntu.1910.Amd64.Open CoreCLR ConnectCancellableTask
6/14 PR #54099 Centos.8.Amd64.Open Mono ConnectSync
6/14 PR #53606 Debian.10.Amd64.Open CoreCLR ConnectCancellableTask
6/16 PR #54250 Debian.10.Amd64.Open Mono ConnectTask
6/16 PR #54245 Fedora.30.Amd64.Open CoreCLR ConnectSync
6/16 PR #54245 Fedora.30.Amd64.Open CoreCLR ConnectTask
6/17 PR #54040 SLES.15.Amd64.Open Mono ConnectTask
6/18 PR #53450 Debian.10.Amd64.Open Mono ConnectSync
6/18 PR #54305 Fedora.30.Amd64.Open CoreCLR ConnectTask
6/18 Official run Fedora.30.Amd64.Open CoreCLR ConnectSync
6/18 PR #53450 SLES.15.Amd64.Open Mono ConnectSync
6/18 PR #54281 Debian.9.Amd64.Open Mono ConnectTask
6/18 PR #54246 SLES.15.Amd64.Open Mono ConnectTask
6/19 PR #54207 Centos.8.Amd64.Open Mono ConnectSync
6/19 PR #54261 Debian.9.Amd64.Open Mono ConnectApm
6/20 PR #54451 Debian.9.Amd64.Open Mono ConnectCancellableTask
6/21 PR #54477 Debian.10.Amd64.Open Mono ConnectSync
6/21 PR #54246 SLES.15.Amd64.Open CoreCLR ConnectSyncForceNonBlocking
6/21 PR #54218 Debian.10.Amd64.Open Mono ConnectCancellableTask
6/21 PR #54136 Debian.10.Amd64.Open Mono ConnectCancellableTask
6/22 Official run Debian.10.Amd64.Open Mono ConnectSync
6/22 PR #54253 Alpine.312.Amd64.Open CoreCLR ConnectTask
6/22 PR #49737 Fedora.30.Amd64.Open Mono ConnectTask
6/22 PR #54511 Debian.10.Amd64.Open CoreCLR ConnectSync
6/22 PR #54578 Fedora.30.Amd64.Open Mono ConnectTask
6/23 PR #54518 Debian.10.Amd64.Open CoreCLR ConnectApm
6/23 PR #54253 Fedora.30.Amd64.Open Mono ConnectSync
6/23 PR #54595 SLES.15.Amd64.Open Mono ConnectEap
6/23 Official run Centos.8.Amd64.Open Mono ConnectCancellableTask
6/23 PR #54544 SLES.15.Amd64.Open CoreCLR ConnectTask
6/23 PR #54568 Fedora.30.Amd64.Open Mono ConnectEap
6/23 PR #54053 SLES.15.Amd64.Open CoreCLR ConnectCancellableTask
6/23 PR #54621 Fedora.30.Amd64.Open CoreCLR ConnectCancellableTask
6/23 PR #54625 Centos.8.Amd64.Open CoreCLR ConnectEap
Author: karelz
Assignees: -
Labels:

area-System.Net.Sockets, test-run-core
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 24, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Jun 24, 2021
@karelz
Copy link
Member Author

karelz commented Jun 24, 2021

@antonfirsov this looks like recent regression -- any idea why?
We should disable the test ASAP -- 50 failures in 18 days.

@karelz karelz mentioned this issue Jun 24, 2021
Closed
@antonfirsov
Copy link
Member

This is a new test introduced in #53581. Looks like client.LocalEndpoint doesn't get mapped to IPv6:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs

Line 132 in 0d31ddb

Assert.Equal(IPAddress.Loopback.MapToIPv6(), localEndPoint.Address);

Likely a product bug, only affects Linux.

@tmds any tips what is going wrong here?

@antonfirsov antonfirsov added the os-linux Linux OS (any supported distro) label Jun 24, 2021
@antonfirsov antonfirsov mentioned this issue Jun 24, 2021
Merged
@antonfirsov
Copy link
Member

antonfirsov commented Jun 24, 2021 •
edited
Loading

If I get #53447 (comment) right, the bug pointed out in that issue is probably still present.

@tmds
Copy link
Member

tmds commented Jun 24, 2021

@antonfirsov I think we need to update the test expectation and allow both

 ::ffff:127.0.0.1
 ::1

as values for LocalEndPoint.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 24, 2021
@danmoseley
Copy link
Member

Hit this just now on SLES15 Arm64 in the preview 6 branch.

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 29, 2021
@karelz karelz mentioned this issue Jul 2, 2021
Closed
@karelz
Copy link
Member Author

karelz commented Jul 20, 2021 •
edited
Loading

This is still happening -- see updated table above, reopening

Also note that after attempted fix, some failures changed to different manifestation - see #55709

@karelz karelz reopened this Jul 20, 2021
@karelz karelz mentioned this issue Jul 20, 2021
Closed
@karelz karelz changed the title Connect_DualMode_DnsConnect_RetrievedEndPoints_Success fails Connect_DualMode_DnsConnect_RetrievedEndPoints_Success - Assert ::1 Jul 20, 2021
karelz added a commit that referenced this issue Jul 20, 2021
@karelz
Disable test Connect_DualMode_DnsConnect_RetrievedEndPoints_Success o…
5f02794 
…n Linux

Disabled test tracked by #54677 and #55709
@karelz karelz mentioned this issue Jul 20, 2021
Merged
karelz added a commit that referenced this issue Jul 20, 2021
@karelz
Disable test Connect_DualMode_DnsConnect_RetrievedEndPoints_Success o…
5026c25 
…n Linux (#56003)

Disabled test tracked by #54677 and #55709
@karelz karelz added the disabled-test The test is disabled in source code against the issue label Jul 20, 2021
@karelz
Copy link
Member Author

karelz commented Jul 20, 2021 •
edited
Loading

Test disabled on Linux in PR #56003 on 7/20

@antonfirsov antonfirsov mentioned this issue Jul 23, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antonfirsov antonfirsov

Labels
area-System.Net.Sockets disabled-test The test is disabled in source code against the issue os-linux Linux OS (any supported distro) test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix Connect_DualMode_DnsConnect_RetrievedEndPoints_Success on Linux dotnet/runtime
4 participants
@tmds @karelz @danmoseley @antonfirsov