Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics IPC environment variable commands #52567

Merged
merged 7 commits into from
May 13, 2021

Conversation

davmason
Copy link
Member

Follow up to #52175 that adds the ability to set and retrieve environment variables over the IPC.

CC @karpinsn, it won't let me add you as a reviewer for some reason

@davmason davmason added this to the 6.0.0 milestone May 10, 2021
@davmason davmason requested review from noahfalk, jander-msft, josalem and a team May 10, 2021 21:22
@davmason davmason self-assigned this May 10, 2021
@davmason davmason requested a review from marek-safar as a code owner May 10, 2021 21:22
@ghost
Copy link

ghost commented May 10, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up to #52175 that adds the ability to set and retrieve environment variables over the IPC.

CC @karpinsn, it won't let me add you as a reviewer for some reason

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr

Milestone: 6.0.0

@davmason
Copy link
Member Author

@noahfalk @josalem are there any outstanding concerns about this?

@josalem
Copy link
Contributor

josalem commented May 13, 2021

I don't believe so. Let me approve this one and I can update the other pending PR that touches the Process Command ID set after this merges.

@davmason davmason merged commit d156b9e into dotnet:main May 13, 2021
@davmason
Copy link
Member Author

Thanks @josalem

@ghost ghost locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants