-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new DiagnosticClient commands for IPC features #2268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - would be nice if you can also include a docs change in documentation/diagnostics-client-library-instructions.md since there are some public API additions. The test failures also seem to be coming from runtime that doesn't support the command so... may need to target the tests to versions that support this command after the runtime change gets merged
022bc7a
to
f45da35
Compare
@mikem8361 @hoyosjs I see failures like this:
I don't see how my changes could cause this. Is this a known issue? |
The M.D.NETCore.Client's DiagnosticsClient.WriteDump API is failing before the message gets sent to the runtime and it looks like you made a lot of changes to that assembly that affected the WriteDump API. |
Ah, I see. Thanks Mike. I will take a look at that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions, but otherwise this LGTM
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
Show resolved
Hide resolved
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcCommands.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsIpc/IpcMessage.cs
Outdated
Show resolved
Hide resolved
|
||
This sample shows how to request that the runtime use an ICorProfiler as the startup profiler (not as an attaching profiler). It is only valid to issue this command while the runtime is paused in "reverse server" mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reversed server is orthogonal, the runtime just needs to be paused at startup? That startup pause can be accomplished regardless whether the port is listening or connecting:
export DOTNET_DiagnosticPorts=foo.sock,connect,suspend
OR
export DOTNET_DiagnosticPorts=foo.sock,listen,suspend
Client commands for dotnet/runtime#52175 and dotnet/runtime#52567