Don't recompute preds lists during loop cloning #51757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, add and modify the appropriate preds when the mechanical cloning is performed. This will preserve existing profile data on the edges. Contributes to dotnet#49030 No x86/x64 SPMI asm diffs.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndyAyersMS
approved these changes
Apr 24, 2021
| @@ -2606,20 +2607,26 @@ void Compiler::optIdentifyLoopsForAlignment() | |||
| #endif | |||
| } | |||
|
|
|||
| void Compiler::optRedirectBlock(BasicBlock* blk, BlockToBlockMap* redirectMap) | |||
| void Compiler::optRedirectBlock(BasicBlock* blk, BlockToBlockMap* redirectMap, const bool addPreds) | |||
There was a problem hiding this comment.
Will add to the to-do list.
This was referenced May 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, add and modify the appropriate preds when the mechanical
cloning is performed. This will preserve existing profile data
on the edges.
Contributes to #49030
No x86/x64 SPMI asm diffs.