Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hosted pools to send libraries tests to helix to ease out our build pools #49497

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Use hosted pools to send libraries tests to helix to ease out our build pools #49497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion eng/pipelines/libraries/run-test-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ jobs:
timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
container: '' # we just send to helix, no need to use a container.
condition: ${{ parameters.condition }}
pool: ${{ parameters.pool }}
testScope: ${{ parameters.testScope }}
runTests: true
${{ if ne(parameters.liveRuntimeBuildConfig, '') }}:
Expand All @@ -55,6 +54,14 @@ jobs:
${{ if eq(parameters.interpreter, 'true') }}:
testDisplayName: ${{ parameters.runtimeFlavor }}_interpreter_${{ parameters.liveRuntimeBuildConfig }}

# To run the tests we just send to helix and wait, use ubuntu hosted pools for faster providing and to not back up our build pools
${{ if startsWith(parameters.pool.queue, 'BuildPool.Ubuntu') }}:
pool:
vmImage: 'ubuntu-latest'

${{ if not(startsWith(parameters.pool.queue, 'BuildPool.Ubuntu')) }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not do the same with non-Ubuntu pools? Seems a waste. Also how much of the build does this job download? We were hitting the 10gb+ limit on the publishing job, just want to make sure we are not getting close to that when doing this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS already use hosted pools. I decided not to move windows to hosted pools to be careful about hitting the 200 parallel jobs on hosted pools across the org. We don't have as many windows legs as we do ubuntu pool based legs, so that's why I kept windows out. My first commit did include Windows, but I removed it after thinking about that.

Let me know if you think otherwise and we can include Windows here.

pool: ${{ parameters.pool }}

dependOnEvaluatePaths: ${{ parameters.dependOnEvaluatePaths }}
dependsOn:
- ${{ if ne(parameters.dependsOn[0], '') }}:
Expand Down