-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hosted pools to send libraries tests to helix to ease out our build pools #49497
Conversation
Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik Issue Details
|
pool: | ||
vmImage: 'ubuntu-latest' | ||
|
||
${{ if not(startsWith(parameters.pool.queue, 'BuildPool.Ubuntu')) }}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not do the same with non-Ubuntu pools? Seems a waste. Also how much of the build does this job download? We were hitting the 10gb+ limit on the publishing job, just want to make sure we are not getting close to that when doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MacOS already use hosted pools. I decided not to move windows to hosted pools to be careful about hitting the 200 parallel jobs on hosted pools across the org. We don't have as many windows legs as we do ubuntu pool based legs, so that's why I kept windows out. My first commit did include Windows, but I removed it after thinking about that.
Let me know if you think otherwise and we can include Windows here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind as much. Mostly a question to know if there was a reason. If you think we are good on storage this lgtm given that this is mostly in response to resource constraints.
No description provided.