Single Transport Package for aspnetcore #47684

Anipik · 2021-01-30T20:48:56Z

Move non extensions libraries to the transport package
change the transport package name
update the servicing policy
move the build of transport package to just allconfig leg

depends on dotnet/arcade#6886 to bin place the .xml files

…rt package to all config leg

….AspNetCore.Internal.Transport

ghost · 2021-01-30T20:49:05Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Move non extensions libraries to the transport package
change the transport package name
update the servicing policy
move the build of transport package to just allconfig leg

depends on dotnet/arcade#6886 to bin place the .xml files

Author:	Anipik
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

dougbu

Is the plan to produce a separate transport package for WindowsDesktop❔ I'm pretty sure they also (like dotnet/aspnetcore) special-case runtime packages that ship in their targeting pack.

dougbu · 2021-01-30T21:29:03Z

docs/project/library-servicing.md

@@ -29,9 +29,20 @@ If this library ships both inbox on a platform and in its own library package th
 ```
 Where the `AssemblyVersion` is set to the old version before updating. To determine if the library ships inbox you can look at for `InboxOnTargetFramework` item groups or `TreatAsOutOfBox` suppressions in the pkgproj for the library.

+If the library is part of a Aspnetcore or .NET targeting pack then we cannot increment the assembly version. For Aspnetcore, You can examine the ```<IsAspNetCoreApp>true</IsAspNetCoreApp>``` property in the library`s ```Directory.Build.Props```


What about WindowsDesktop❔

@ericstj who will be the best person to tell us on what packages are used by windowsDesktop in their targeting pack ?

I don't know whom, but you could try spot checking them in the targeting pack installed in your dotnet SDK.

ViktorHofer

Should the implicit value (Microsoft.Extensions.*) be changed to be explicit?

runtime/src/libraries/NetCoreAppLibrary.props

Line 164 in 75d5cc3

    
           <IsAspNetCoreApp Condition="$(MSBuildProjectName.StartsWith('Microsoft.Extensions.'))">true</IsAspNetCoreApp>

...s/Microsoft.AspNetCore.Internal.Transport/src/Microsoft.AspNetCore.Internal.Transport.csproj

src/libraries/Microsoft.Win32.Registry/Directory.Build.props

Anipik · 2021-02-02T05:26:51Z

Should the implicit value (Microsoft.Extensions.*) be changed to be explicit?

do you mean setting IsAspNetCoreApp in directory.build.props for extensions project as well ?

ViktorHofer · 2021-02-02T16:05:53Z

do you mean setting IsAspNetCoreApp in directory.build.props for extensions project as well ?

Right. Currently we assume that all libraries which name start with Microsoft.Extensions.* are are aspnetcore libraries which isn't true for some. My question is about if we should stop doing that and just add the property to libraries that are relevant to aspnetcore.

Anipik · 2021-02-03T17:58:07Z

Right. Currently we assume that all libraries which name start with Microsoft.Extensions.* are are aspnetcore libraries which isn't true for some. My question is about if we should stop doing that and just add the property to libraries that are relevant to aspnetcore.

yes i think we should do that, because as we are planning on bring the hosting packages and those packages i dont think will be part of this package.

ViktorHofer

Are all of the libs where you set IsAspNetCoreApp needed by aspnetcore?

Anipik · 2021-02-05T03:29:27Z

@dougbu are there any extensions projects here that are not needed by the aspnetcore

dougbu · 2021-02-05T05:23:22Z

@dougbu are there any extensions projects here that are not needed by the aspnetcore

The concise list of all assemblies expected in Microsoft.AspNetCore.App.Ref (what we'll get from the transport package) is https://github.com/dotnet/aspnetcore/blob/43a348b22468be9ed46ff1681cc113c9598b9f25/src/Framework/test/TestData.cs#L155-L288. Note that list includes more from dotnet/runtime than Microsoft.Extensions.* as well as our own ref/ assemblies.

src/libraries/Microsoft.Extensions.DependencyModel/Directory.Build.props

ViktorHofer · 2021-02-05T17:10:18Z

src/libraries/Microsoft.Extensions.HostFactoryResolver/Directory.Build.props

@@ -2,5 +2,6 @@
  <Import Project="..\Directory.Build.props" />
  <PropertyGroup>
    <PackageDescription>Internal package for sharing Microsoft.Extensions.Hosting.HostFactoryResolver type.</PackageDescription>
+    <IsAspNetCoreApp>true</IsAspNetCoreApp>


I don't see this library in aspnetcore's list. @dougbu is this one needed?

Right, this isn't a library. aspnetcore uses the Microsoft.Extensions.HostFactoryResolver.Sources package but (of course) doesn't ship an assembly with this name.

@Anipik that's that package, so you want to keep <IsAspNetCoreApp> as that's the source package that aspnetcore needs.

- handle Microsoft.Extensions.Internal.Transport -> 'Microsoft.AspNetCore.Internal.Transport name change - remove `$(...V0Version)` / `%(RTMVersion)` workarounds - remove mention of System.Security.AccessControl package; only need transitive references to that - confirm content of Microsoft.AspNetCore.Internal.Transport package - missing Microsoft.Extensions.DependencyModel assembly

* React to dotnet/runtime#47684, a new transport package - handle Microsoft.Extensions.Internal.Transport -> 'Microsoft.AspNetCore.Internal.Transport name change - remove `$(...V0Version)` / `%(RTMVersion)` workarounds - remove mention of System.Security.AccessControl package; only need transitive references to that - confirm content of Microsoft.AspNetCore.Internal.Transport package - missing Microsoft.Extensions.DependencyModel assembly * Remove unnecessary `using`s - namespace previously available due to Microsoft.Extensions.Internal.Transport dependency - no need for Microsoft.AspNetCore.Internal.Transport dependency * nit: Clean up "Extensions" naming in Ref project * Correct targeting pack content - intersection w/ `@(ExternalAspNetCoreAppReference)` items added nothing - excluded assemblies now included in transport package

- back-port from main / dotnet#30405 * React to dotnet/runtime#47684, a new transport package - handle Microsoft.Extensions.Internal.Transport -> 'Microsoft.AspNetCore.Internal.Transport name change - remove `$(...V0Version)` / `%(RTMVersion)` workarounds - remove mention of System.Security.AccessControl package; only need transitive references to that - confirm content of Microsoft.AspNetCore.Internal.Transport package - missing Microsoft.Extensions.DependencyModel assembly * Remove unnecessary `using`s - namespace previously available due to Microsoft.Extensions.Internal.Transport dependency - no need for Microsoft.AspNetCore.Internal.Transport dependency * nit: Clean up "Extensions" naming in Ref project * Correct targeting pack content - intersection w/ `@(ExternalAspNetCoreAppReference)` items added nothing - excluded assemblies now included in transport package

…#30461) - back-port from main / #30405 * React to dotnet/runtime#47684, a new transport package - handle Microsoft.Extensions.Internal.Transport -> 'Microsoft.AspNetCore.Internal.Transport name change - remove `$(...V0Version)` / `%(RTMVersion)` workarounds - remove mention of System.Security.AccessControl package; only need transitive references to that - confirm content of Microsoft.AspNetCore.Internal.Transport package - missing Microsoft.Extensions.DependencyModel assembly * Remove unnecessary `using`s - namespace previously available due to Microsoft.Extensions.Internal.Transport dependency - no need for Microsoft.AspNetCore.Internal.Transport dependency * nit: Clean up "Extensions" naming in Ref project * Correct targeting pack content - intersection w/ `@(ExternalAspNetCoreAppReference)` items added nothing - excluded assemblies now included in transport package Co-authored-by: Doug Bunting <[email protected]>

Anipik added 3 commits January 30, 2021 12:40

Adding non ectensions library to transport package and moving transpo…

9b16b0f

…rt package to all config leg

update servicing policy doc

834413f

change name from Microsoft.Extensions.Internal.Transport -> Microsoft…

8e03587

….AspNetCore.Internal.Transport

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Jan 30, 2021

Anipik requested review from ViktorHofer, safern, ericstj and dougbu January 30, 2021 20:49

dougbu reviewed Jan 30, 2021

View reviewed changes

ViktorHofer reviewed Feb 1, 2021

View reviewed changes

...s/Microsoft.AspNetCore.Internal.Transport/src/Microsoft.AspNetCore.Internal.Transport.csproj Outdated Show resolved Hide resolved

ViktorHofer reviewed Feb 1, 2021

View reviewed changes

...s/Microsoft.AspNetCore.Internal.Transport/src/Microsoft.AspNetCore.Internal.Transport.csproj Outdated Show resolved Hide resolved

ViktorHofer reviewed Feb 1, 2021

View reviewed changes

...s/Microsoft.AspNetCore.Internal.Transport/src/Microsoft.AspNetCore.Internal.Transport.csproj Outdated Show resolved Hide resolved

ericstj reviewed Feb 1, 2021

View reviewed changes

src/libraries/Microsoft.Win32.Registry/Directory.Build.props Show resolved Hide resolved

Anipik added 2 commits February 3, 2021 14:22

make isAspnetCore property explicit

a9b045e

csproj to proj change

dd57173

ViktorHofer approved these changes Feb 4, 2021

View reviewed changes

Merge branch 'master' into servicing

9df54ef

ViktorHofer reviewed Feb 5, 2021

View reviewed changes

src/libraries/Microsoft.Extensions.DependencyModel/Directory.Build.props Outdated Show resolved Hide resolved

ViktorHofer reviewed Feb 5, 2021

View reviewed changes

remove non used extensions assemblies from transport package

68f7e34

runfoapp bot mentioned this pull request Feb 5, 2021

Inability to unzip assets during build on Unix x64 #32805

Closed

Update Directory.Build.props

65f679d

Anipik merged commit a66b4e3 into dotnet:master Feb 8, 2021

Anipik deleted the servicing branch February 8, 2021 08:03

Anipik mentioned this pull request Feb 9, 2021

update servicing docs to reflect the new policy #48030

Merged

ghost locked as resolved and limited conversation to collaborators Mar 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Single Transport Package for aspnetcore #47684

Single Transport Package for aspnetcore #47684

Anipik commented Jan 30, 2021

ghost commented Jan 30, 2021

dougbu left a comment

dougbu Jan 30, 2021

Anipik Feb 2, 2021

safern Feb 3, 2021

ViktorHofer left a comment

Anipik commented Feb 2, 2021

ViktorHofer commented Feb 2, 2021

Anipik commented Feb 3, 2021

ViktorHofer left a comment

Anipik commented Feb 5, 2021

dougbu commented Feb 5, 2021

ViktorHofer Feb 5, 2021

dougbu Feb 5, 2021

ViktorHofer Feb 5, 2021

Single Transport Package for aspnetcore #47684

Single Transport Package for aspnetcore #47684

Conversation

Anipik commented Jan 30, 2021

ghost commented Jan 30, 2021

dougbu left a comment

Choose a reason for hiding this comment

dougbu Jan 30, 2021

Choose a reason for hiding this comment

Anipik Feb 2, 2021

Choose a reason for hiding this comment

safern Feb 3, 2021

Choose a reason for hiding this comment

ViktorHofer left a comment

Choose a reason for hiding this comment

Anipik commented Feb 2, 2021

ViktorHofer commented Feb 2, 2021

Anipik commented Feb 3, 2021

ViktorHofer left a comment

Choose a reason for hiding this comment

Anipik commented Feb 5, 2021

dougbu commented Feb 5, 2021

ViktorHofer Feb 5, 2021

Choose a reason for hiding this comment

dougbu Feb 5, 2021

Choose a reason for hiding this comment

ViktorHofer Feb 5, 2021

Choose a reason for hiding this comment