[release/6.0-preview2] React to Microsoft.Extensions.Internal.Transport package name change #30461
+33
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
mmitche
changed the title
|
@mmitche not exactly a breaking change. Microsoft.Extensions.DependencyModel is no longer in the transport package. That's fine but a couple of projects used that namespace without depending on the package. Turns out the Long story short, cherry-pick the rest of #30405 in here or wait for me to merge that and use the squashed commit instead of what you've got here. |
- back-port from main / dotnet#30405 * React to dotnet/runtime#47684, a new transport package - handle Microsoft.Extensions.Internal.Transport -> 'Microsoft.AspNetCore.Internal.Transport name change - remove `$(...V0Version)` / `%(RTMVersion)` workarounds - remove mention of System.Security.AccessControl package; only need transitive references to that - confirm content of Microsoft.AspNetCore.Internal.Transport package - missing Microsoft.Extensions.DependencyModel assembly * Remove unnecessary `using`s - namespace previously available due to Microsoft.Extensions.Internal.Transport dependency - no need for Microsoft.AspNetCore.Internal.Transport dependency * nit: Clean up "Extensions" naming in Ref project * Correct targeting pack content - intersection w/ `@(ExternalAspNetCoreAppReference)` items added nothing - excluded assemblies now included in transport package
dougbu
force-pushed
the
update-package-name
branch
from
3b709a2 to
c7e4709
Compare
Anipik
approved these changes
Feb 26, 2021
|
Thanks for alerting us this was needed for 6.0 @mmitche❕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package name changed to Microsoft.AspNetCore.Internal.Transport