Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TplEventSource.TaskWaitContinuation* events #46304

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix TplEventSource.TaskWaitContinuation* events #46304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TplEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ public void TaskWaitEnd(
public void TaskWaitContinuationComplete(int TaskID)
{
// Log an event if indicated.
if (IsEnabled() && IsEnabled(EventLevel.Verbose, Keywords.Tasks))
if (IsEnabled() && IsEnabled(EventLevel.Verbose, Keywords.TaskStops))
WriteEvent(TASKWAITCONTINUATIONCOMPLETE_ID, TaskID);
}

Expand All @@ -373,7 +373,7 @@ public void TaskWaitContinuationComplete(int TaskID)
/// </summary>
/// <param name="TaskID">The task ID.</param>
[Event(TASKWAITCONTINUATIONSTARTED_ID,
Level = EventLevel.Verbose, Keywords = Keywords.TaskStops)]
Level = EventLevel.Verbose, Keywords = Keywords.Tasks)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth double-checking whether this is going to break any tooling in Visual Studio, i.e. that Tasks is being specified in addition to TaskStops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Thanks!

public void TaskWaitContinuationStarted(int TaskID)
{
// Log an event if indicated.
Expand Down