Fix TplEventSource.TaskWaitContinuation* events #46304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jan 4, 2021
| @@ -373,7 +373,7 @@ public void TaskWaitContinuationComplete(int TaskID) | |||
| /// </summary> | |||
| /// <param name="TaskID">The task ID.</param> | |||
| [Event(TASKWAITCONTINUATIONSTARTED_ID, | |||
| Level = EventLevel.Verbose, Keywords = Keywords.TaskStops)] | |||
| Level = EventLevel.Verbose, Keywords = Keywords.Tasks)] | |||
There was a problem hiding this comment.
It might be worth double-checking whether this is going to break any tooling in Visual Studio, i.e. that Tasks is being specified in addition to TaskStops.
stephentoub
approved these changes
Jan 4, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskWaitContinuationCompleteandTaskWaitContinuationStartedhave mismatching checks between the event declaration and theIsEnabledcheck for them.Both
TaskWaitContinuationStartedandTaskWaitContinuationCompleteare declared as an event with keywordKeywords.TaskStopsbut it is being checked with a keywordKeywords.Tasks.I believe the correct way is to declare
TaskWaitContinuationStartedevent withKeywords.Tasksinstead ofKeywords.TaskStops, and changeIsEnabledcheck to useKeywords.TaskStopsforTaskWaitContinuationComplete.