Remove pr: none clause from several CoreCLR pipelines #42933
Conversation
|
It looks like you missed runtime-coreclr outerloop? (just fixed that in AzDO) |
| @@ -24,9 +24,6 @@ trigger: | |||
| - eng/pipelines/libraries/* | |||
| - eng/pipelines/runtime.yml | |||
|
|
|||
|
|
|||
| pr: none | |||
There was a problem hiding this comment.
Do we ever want this pipeline to be triggerable?
There was a problem hiding this comment.
Or is that the outerloop pipeline?
There was a problem hiding this comment.
Yes, ci.yml corresponds to the "runtime-coreclr outerloop" pipeline. I think we should rename the YAML script to "outerloop.yml", this is an endless cause of confusion.
There was a problem hiding this comment.
I proposed to rename it before as well. However, if we rename it now, we will need to port that to release/5.0 and release/5.0-rc2 branch.
There was a problem hiding this comment.
Maybe it's just busywork. I would say let's leave this for a more suitable time when there are no porting concerns.
|
Hmm would be great if you could amend your commit or do something so that CI is retriggered. |
|
Good, I think the outerloop is no longer automatically triggered upon the PR, I fixed the pipeline parameters in the AzDO UI editor. |
|
/azp:run runtime-coreclr crossgen2 |
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ViktorHofer - any additional feedback on this change you asked me to make? Or is there some remaining feedback from you I haven't yet addressed? |
|
Hmm wasn't there an issue that was tracking this work? |
|
Thanks Tomas! |
ghost
locked as resolved and limited conversation to collaborators
I have updated the AzDO UI properties per Viktor's advice to enable these runs for
/asp runruns. After verifying they work as expected we can expand the pipeline set. For now I have skipped the various stress runs that would be the most detrimental if they unexpectedly started to run as part of PR's as an unforeseen effect of the changes.Thanks
Tomas
/cc @dotnet/runtime-infrastructure