Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/azp run can't start a pipeline if it is marked as pr: none #32777

Closed
sandreenko opened this issue Feb 25, 2020 · 14 comments
Closed

/azp run can't start a pipeline if it is marked as pr: none #32777

sandreenko opened this issue Feb 25, 2020 · 14 comments

Comments

@sandreenko
Copy link
Contributor

sandreenko commented Feb 25, 2020

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Originally posted by @azure-pipelines in #32362 (comment)

with /azp list you can get the list of the available pipeline, but if you try to trigger them you will see:
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
because they have that setting:

So if we want to be able to trigger something with /azp run pipeline name we need to do the workaround from https://github.com/MicrosoftDocs/vsts-docs/issues/4206

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Feb 25, 2020
@karelz
Copy link
Member

karelz commented Feb 27, 2020

@sandreenko only 1 area label please - see why

@ViktorHofer
Copy link
Member

@trylek @safern do we know if this will change on the AzDO side? If not, I don't think this item is actionable and should be closed.

@trylek
Copy link
Member

trylek commented Sep 26, 2020

Well, so far I'm not aware of any indication that AzDO would be planning to roll out a fix / new functionality addressing this issue in the short term especially as this is kind of a feature request rather than a mere bugfix.

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 26, 2020

Can you please remind me why some pipelines like the one mentioned in the top aren't triggerable? How is this pipeline different from the libraries outerloop which is triggerable?

@sandreenko
Copy link
Contributor Author

Can you please remind me why some pipelines like the one mentioned in the top aren't triggerable? How is this pipeline different from the libraries outerloop which is triggerable?

I think the task is:

  1. trigger only a small amount of pipelines are when you run /azp run;
  2. make all optional heavy pipelines triggerable with /azp run NAME;

right now if we delete pr: none from all pipelines when you do /azp run it will run them all, that is undesirable for jit GCStress jobs etc. that are taking hours and many machines. But with pr: none you can't get the second.

@ViktorHofer
Copy link
Member

Isn't /azp run already a no-op in dotnet/runtime as we set the pipeline limit to 10 and we have more than that?

@safern
Copy link
Member

safern commented Sep 29, 2020

I think if we just remove the PR triggers and then set the options on the UI that the pipeline requires a comment to run, it would solve this issue.

Isn't /azp run already a no-op in dotnet/runtime as we set the pipeline limit to 10 and we have more than that?

Yeah, this would happen and no pipelines would run, so I'm OK with removing the PR trigger section from the yml file.

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 30, 2020

@trylek can you help with that as you know which coreclr pipelines make sense to be triggered by an /azp command? I believe we just need to remove the pr: none entries and then mimic the pipelines UI settings with what we already have for libraries outerloop:

image

@trylek
Copy link
Member

trylek commented Sep 30, 2020

If I'm right to understand that we still operate under the limitation that "/azp run" runs all the eligible pipelines, I guess we should only support a relatively small number of pipelines to avoid clogging the system by use of the parameterless command. I guess this rules out all the stress tests and mostly leaves in pipelines representing build variations - R2R, Crossgen2, maybe jit-experimental. Adding @BruceForstall who has the best knowledge of our pipeline portfolio and its usefulness to chime in.

@ViktorHofer
Copy link
Member

/azp run doesn't do anything as we exceed the specified pipeline limit (10): #41620 (comment)

@trylek
Copy link
Member

trylek commented Sep 30, 2020

OK, in such case I guess I'll just modify the UI settings for all pipelines as you described above and then we can arbitrarily start removing the pr: none specifiers.

@ViktorHofer
Copy link
Member

Thanks Tomas

@sandreenko
Copy link
Contributor Author

As I saw we now can trigger many pipelines with /azp run, it was fixed by #42933, @trylek should this issue be closed?

@ViktorHofer
Copy link
Member

Yes, we can close the issue now. Thanks

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants