IsSupported reports SocketsHttpHandler availability on different platforms #40271
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl |
| @@ -35,6 +35,8 @@ private void CheckDisposedOrStarted() | |||
| } | |||
| } | |||
|
|
|||
| public static bool IsSupported => true; | |||
There was a problem hiding this comment.
This needed xml doc comments.
There was a problem hiding this comment.
I will add it, but could you please clarify what are the rules about them?
I see a lot of existing public properties without comments e.g. Expected100ContinueTimeout and AFAIK the xml doc content doesn't get automatically copied to dotnet/dotnet-api-docs repo. Previously, I had to manually create PR in the doc repo for new members (see HttpRequestException.StatusCode)
There was a problem hiding this comment.
(Note the comment the bot added to the PR: #40271 (comment). The XML comments on new APIs are then ported to the docs.)
There was a problem hiding this comment.
This is a strange API. What value are we going to return for example on iOS where the API does not work fully and we'll discourage usage of it (probably using some analyzers) because it's inefficient?
ghost
locked as resolved and limited conversation to collaborators
Fixes #39489