Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpRequestException.StatusCode property and ctor #4341

Merged
merged 2 commits into from
Jun 12, 2020
Merged

HttpRequestException.StatusCode property and ctor #4341

merged 2 commits into from
Jun 12, 2020

Conversation

alnikola
Copy link
Contributor

@alnikola alnikola commented Jun 5, 2020

HttpRequestException.StatusCode property gets the HTTP status code associated with the exception if any.

It was introduced in dotnet/runtime#32455

@alnikola alnikola requested review from carlossanlop, mairaw, gewarren and a team June 5, 2020 15:33
@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 5, 2020
gewarren
gewarren requested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cref link needs the full ID string. You can see that it doesn't render in the preview:

https://review.docs.microsoft.com/en-us/dotnet/api/system.net.http.httprequestexception.-ctor?view=net-5.0&branch=pr-en-us-4341#System_Net_Http_HttpRequestException__ctor_System_String_System_Exception_System_Nullable_System_Net_HttpStatusCode__

xml/System.Net.Http/HttpRequestException.xml Outdated Show resolved Hide resolved
xml/System.Net.Http/HttpRequestException.xml Outdated Show resolved Hide resolved
@mairaw mairaw removed their request for review June 10, 2020 05:58
@alnikola @gewarren
Apply suggestions from code review
dd3e622 
Co-authored-by: Genevieve Warren <[email protected]>
@alnikola
Copy link
Contributor Author

@gewarren crefs have been fixed. Please, check.

@alnikola alnikola merged commit f9e83bd into master Jun 12, 2020
@alnikola alnikola deleted the alnikola/httprequestexception-statuscode branch June 12, 2020 16:45
@alnikola alnikola mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelz karelz karelz approved these changes

@gewarren gewarren gewarren approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@alnikola @karelz @gewarren @dotnet-bot