Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't probe for A/W variants of entry points on non-Windows. #33250

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Don't probe for A/W variants of entry points on non-Windows. #33250

merged 4 commits into from
Mar 11, 2020

Conversation

jkoritzinsky
Copy link
Member

Fixes #33246 for CoreCLR

@jkoritzinsky jkoritzinsky added this to the 5.0 milestone Mar 5, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't add an area label to this PR.

Checkout this page to find out which area owner to ping, or please add exactly one area label to help train me in the future.

stephentoub
stephentoub reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add any tests to validate expected behavior?

@jkotas jkotas added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Mar 5, 2020
@AaronRobinsonMSFT
Copy link
Member

@stephentoub I agree. Anytime we add the 'breaking-change' tag some level of testing should be a requirement.

@jkoritzinsky
Copy link
Member Author

I've updated the ExactSpelling tests to test the new behavior.

@jkotas jkotas merged commit a6fcb15 into dotnet:master Mar 11, 2020
@jkoritzinsky jkoritzinsky deleted the aw-windows-only branch March 11, 2020 04:42
@stephentoub stephentoub mentioned this pull request May 12, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@stephentoub stephentoub stephentoub left review comments

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-Interop-coreclr breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Remove A/W probing for PInvokes on non-Windows platforms
5 participants
@jkoritzinsky @Dotnet-GitSync-Bot @AaronRobinsonMSFT @stephentoub @jkotas