Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove A/W probing for PInvokes on non-Windows platforms #33246

Closed
akoeplinger opened this issue Mar 5, 2020 · 4 comments · Fixed by #33250, #33940 or mono/mono#19281
Closed

Remove A/W probing for PInvokes on non-Windows platforms #33246

akoeplinger opened this issue Mar 5, 2020 · 4 comments · Fixed by #33250, #33940 or mono/mono#19281
Labels
area-Interop-coreclr breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Milestone
5.0.0

Comments

@akoeplinger
Copy link
Member

akoeplinger commented Mar 5, 2020 •
edited
Loading

Currently both Mono and CoreCLR have logic to probe for functions ending in W (Unicode) or A (Ansi) when resolving P/Invoke targets.

This doesn't really make sense on non-Windows platforms where such a convention doesn't exist.

From discussion with @jkotas:

CoreCLR does the W/A probing today even on non-Windows. I do not think it makes any sense. I would be ok with doing a breaking change for CoreCLR to remove this probing on non-Windows to make more sensible cross-plat behavior.

/cc @lambdageek @CoffeeFlux
@jkotas jkotas added this to the 5.0 milestone Mar 5, 2020
@jkotas
Copy link
Member

jkotas commented Mar 5, 2020

cc @jkoritzinsky @AaronRobinsonMSFT It would be nice to do this sooner rather than later so that we have enough time to react to feedback if it is problematic.

@CoffeeFlux
Copy link
Contributor

CoffeeFlux commented Mar 5, 2020 •
edited
Loading

Once this change goes in for CoreCLR, I'll PR the corresponding Mono change for netcore only.

@jkoritzinsky jkoritzinsky mentioned this issue Mar 5, 2020
Merged
@jkotas jkotas added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Mar 5, 2020
@jkotas jkotas reopened this Mar 11, 2020
@jkotas
Copy link
Member

jkotas commented Mar 11, 2020

@CoffeeFlux Could you please make matching change for Mono?

@CoffeeFlux
Copy link
Contributor

Will PR today or tomorrow – things are a bit busy today since I'm in the process of transitioning to WFH.

@CoffeeFlux CoffeeFlux mentioned this issue Mar 22, 2020
Merged
@monojenkins monojenkins mentioned this issue Mar 23, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this issue Mar 23, 2020
@CoffeeFlux
[metadata] Skip symbol name mangling on non-Windows for netcore
0c1791a 
Fixes dotnet/runtime#33246
akoeplinger pushed a commit that referenced this issue Mar 25, 2020
@CoffeeFlux
[metadata] Skip symbol name mangling on non-Windows for netcore (#33940)
e7fb47e 
Fixes #33246
akoeplinger pushed a commit to mono/mono that referenced this issue Mar 25, 2020
@monojenkins @CoffeeFlux
[metadata] Skip symbol name mangling on non-Windows for netcore (#19281)
a89b6d3 
Fixes dotnet/runtime#33246

Co-authored-by: CoffeeFlux <[email protected]>
@elinor-fung elinor-fung mentioned this issue May 12, 2020
Merged
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Jul 24, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Interop-coreclr breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
5.0.0
3 participants
@akoeplinger @CoffeeFlux @jkotas