Disable warnaserror for libraries Windows builds. #31909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machines were updated to a newer VS 16.4 but CMake is 3.15.1 which is too old for VS validation of incremental native targets. We need 3.15.5 at least.
safern
changed the title
jkotas
approved these changes
Feb 7, 2020
|
Merging as this works around the issue and to unblock CI. |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #31888
Machines were updated to a newer VS 16.4 but CMake is 3.15.1 which is too old for VS validation of incremental native targets. We need 3.15.5 at least. All PRs and CI are failing on Windows to build Libraries because of this.
@stephentoub @buyaa-n @eiriktsarpalis this would impact nullable as they will be expressed as warnings on PRs. So we have to lookout for those before merging.
Cc: @jkotas @dotnet/runtime-infrastructure