Skip to content

Commit

Permalink
Disable warnaserror for Windows (#31909)
Browse files Browse the repository at this point in the history
Machines were updated to a newer VS 16.4 but CMake is 3.15.1 which is too old for VS validation of incremental native targets. We need 3.15.5 at least.
  • Loading branch information
safern authored Feb 7, 2020
1 parent c0e876f commit 132b3dd
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions eng/pipelines/libraries/base-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,8 @@ jobs:
# Windows variables
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
- _runtimeOSArg: /p:RuntimeOS=win10
- ${{ if eq(parameters.isOfficialBuild, 'true') }}:
# Remove when: https://github.com/dotnet/runtime/issues/31888 is fixed.
- _warnAsErrorArg: -warnAsError:0
# Remove when: https://github.com/dotnet/runtime/issues/31888 is fixed.
- _warnAsErrorArg: -warnAsError:0

# Non-Windows variables
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
Expand Down

0 comments on commit 132b3dd

Please sign in to comment.