[release/9.0-staging] Add forwarding support for WasmLinkage on LibraryImport #109364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AaronRobinsonMSFT
approved these changes
Oct 30, 2024
AaronRobinsonMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Oct 30, 2024
This was referenced Oct 30, 2024
Open
rbhanda
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109234 to release/9.0-staging
/cc @jkoritzinsky
Customer Impact
Consumers trying to use the new
WasmImportLinkageattribute introduced in .NET 9 encounter unexpected and inconsistent failures when usingLibraryImportAttribute, the recommended mechanism for doing interop with C-ABI libraries.This backport introduces the support for
WasmImportLinkagetoLibraryImportAttribute, so the new attribute can be used as our documentation and the attribute's design intend, as well as how our users expect.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
We added tests to verify that the attribute is forwarded to the underlying
DllImportand as such will provide the expected experience.Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low:
LibraryImportis never used in combination withWasmImportLinkagein any product code, so we won't be making any changes to any generated product code with this backport.Additionally, the scope of this change is similar to the scope of similar changes we've backported previously and to changes that are introduced in new SDK bands in code fixes and analyzers shipped in the SDK.