Add forwarding support for WasmLinkage on LibraryImport #109234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
arch-wasm
...ibraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs
Show resolved
Hide resolved
This was referenced Oct 25, 2024
AaronRobinsonMSFT
approved these changes
Oct 29, 2024
|
/Failures look unrelated (as there's no usage of LibraryImport + WasmImportLinkage in the product today.) |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11584351456 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109181
Given that there is no impact in product code today with this generator change, I feel that it may meet the servicing bar (as we've serviced similar generator changes like this before), but it's not worth rushing into GA. If the generator shipped out of band (like in roslyn-analyzers), we'd meet the bar for the next "SDK band" release with a change like this.