Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dotnet/runtime on using Arcade -publish #108990

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Oct 17, 2024

eng/Publishing.props Outdated Show resolved Hide resolved
@ViktorHofer
Copy link
Member

Unfortunately this won't work because of https://github.com/dotnet/arcade/blob/31624193093a13f765ab5382509e693911264509/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj#L98

You will notice this when you update this branch with latest main (which has an updated Arcade). You can fix this by adding an "Empty.proj" file which as the name says is empty and pass that in as a ProjectToBuild item.

@jkoritzinsky
Copy link
Member Author

I wish there was a "restore toolset"-only option... I guess I'll add the empty.csproj. Really hate that pattern.

@jkoritzinsky
Copy link
Member Author

I have an idea on how to avoid the empty.proj pattern. I'll try it out and see what happens.

@ViktorHofer
Copy link
Member

Yeah that's more or less the same just without an additional project. You are now also building the repo tasks unnecessarily but that should be fine.

@ViktorHofer
Copy link
Member

D:\a_work\1\s.packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.24511.1\tools\Publish.proj(310,5): error MSB4044: The "PublishSymbols" task was not given a value for the required parameter "PersonalAccessToken".

@jkoritzinsky
Copy link
Member Author

Looks like we have some repeated assets from the productVersion.txt files. I'll figure out a solution tomorrow.

@ViktorHofer
Copy link
Member

The official build succeeded. Merging to unblock dotnet/sdk#44014.

We can follow-up on whether the main branch should sign everything (real) or not in a follow-up.

@ViktorHofer ViktorHofer merged commit 9e59acb into dotnet:main Oct 23, 2024
154 of 157 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unify publishing infrastructure in runtime
2 participants