-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify dotnet/runtime on using Arcade -publish #108990
Conversation
Fixes dotnet/source-build#4239 Replaces dotnet#100004 Co-authored By: Viktor Hofer <[email protected]>
…VMR-like context, even repo build.
Unfortunately this won't work because of https://github.com/dotnet/arcade/blob/31624193093a13f765ab5382509e693911264509/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj#L98 You will notice this when you update this branch with latest main (which has an updated Arcade). You can fix this by adding an "Empty.proj" file which as the name says is empty and pass that in as a |
I wish there was a "restore toolset"-only option... I guess I'll add the empty.csproj. Really hate that pattern. |
I have an idea on how to avoid the empty.proj pattern. I'll try it out and see what happens. |
…way from the Arcade SDK.
Yeah that's more or less the same just without an additional project. You are now also building the repo tasks unnecessarily but that should be fine. |
|
Looks like we have some repeated assets from the productVersion.txt files. I'll figure out a solution tomorrow. |
The official build succeeded. Merging to unblock dotnet/sdk#44014. We can follow-up on whether the main branch should sign everything (real) or not in a follow-up. |
Fixes dotnet/source-build#4239
Replaces #100004
Current official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2566438&view=results