System.Net.Http.Functional.Tests.TelemetryTest failing with differing string

[tannergooding]

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=847502
Build error leg or test failing: EventSource_ExistsWithCorrectId

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": ["Expected: \"System.Net.Http\"", "Actual:   \"HttpTelemetry\""],
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=847502
Error message validated: [Expected: "System.Net.Http" Actual: "HttpTelemetry"]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/18/2024 7:25:09 PM UTC

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[MihaZupan]

This failure on Browser is already tracked by #71877. The test in question should already be disabled there:

runtime/src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs

Lines 24 to 31 in f87687a

	[Fact]
	[ActiveIssue("https://github.com/dotnet/runtime/issues/71877", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
	public void EventSource_ExistsWithCorrectId()
	{
	Type esType = typeof(HttpClient).Assembly.GetType("System.Net.Http.HttpTelemetry", throwOnError: true, ignoreCase: false);
	Assert.NotNull(esType);
	Assert.Equal("System.Net.Http", EventSource.GetName(esType));

Does WasmTestOnChrome not fall under PlatformDetection.IsBrowser?

[pavelsavara]

Maybe on browser the env variable MONO_AOT_MODE is never set ?

[lewing]

@ilonatommy this and #105363 are getting hit a lot. please take a look

[ilonatommy]

Maybe on browser the env variable MONO_AOT_MODE is never set ?

The test is run with /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=false.

It's true that MONO_AOT_MODE is never set, because ENABLE_AOT is not defined. I guess it should be set here:

runtime/src/tasks/AotCompilerTask/MonoAOTCompiler.cs

Line 1140 in edaa25e

{{parsedAotMode switch

The tests, however fail when AOT = false, so the active issue does not prevent it. We have a detection for EAT on wasm browser, it's this property:

runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

Line 288 in edaa25e

public static bool IsBuiltWithAggressiveTrimming => IsNativeAot || IsAppleMobile;

set by this stub:

runtime/src/libraries/Common/tests/TestUtilities/ILLink.Substitutions.AggressiveTrimming.xml

Line 4 in edaa25e

<method signature="System.Boolean get_IsBuiltWithAggressiveTrimming()" body="stub" value="true" />

from here:

runtime/src/libraries/Common/tests/TestUtilities/TestUtilities.csproj

Line 13 in edaa25e

<EmbeddedResource Include="$(MSBuildThisFileDirectory)ILLink.Substitutions.AggressiveTrimming.xml"

I will add appropriate blocking condition in a PR soon.

[ilonatommy]

About this part:

Maybe on browser the env variable MONO_AOT_MODE is never set ?

It's true that MONO_AOT_MODE is never set, because ENABLE_AOT is not defined.

I found where we're setting it:

runtime/src/mono/browser/build/BrowserWasmApp.targets

Line 319 in edaa25e

<_EmccCFlags Include="-DENABLE_AOT=1" Condition="'$(_WasmShouldAOT)' == 'true'" />

that triggers:

runtime/src/mono/browser/runtime/runtime.c

Lines 308 to 312 in 8e8143e

	#ifdef ENABLE_AOT
	monoeg_g_setenv ("MONO_AOT_MODE", "aot", 1);
	// Defined in driver-gen.c
	register_aot_modules ();

so the existing blocker is also fine.

[ilonatommy]

Browser does not support diagnostics, so in the current state it's expected to trim

runtime/src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs

Line 12 in 8e8143e

[EventSource(Name = "System.Net.Http")]

This can be enabled once we have EP working on WASM browser.