Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try re-enabling some CoreCLR/NativeAOT tests #106514

Merged
merged 17 commits into from
Aug 20, 2024
Merged

Try re-enabling some CoreCLR/NativeAOT tests #106514

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2f42c91
Enable #73454
amanasifkhalid Aug 15, 2024
54d4752
Enable #68690
amanasifkhalid Aug 15, 2024
714ea16
Enable #86112
amanasifkhalid Aug 15, 2024
6a17ff4
Enable #43461
amanasifkhalid Aug 15, 2024
8b90808
Update issue number
amanasifkhalid Aug 15, 2024
14f3bac
Enable #57621
amanasifkhalid Aug 15, 2024
0e31e59
Enable #57458
amanasifkhalid Aug 15, 2024
3522d52
Enable #88586
amanasifkhalid Aug 15, 2024
5b3d496
Enable #101364
amanasifkhalid Aug 15, 2024
51f11ed
Enable #57875
amanasifkhalid Aug 15, 2024
161923d
Enable #8034
amanasifkhalid Aug 15, 2024
06d6970
Update link
amanasifkhalid Aug 15, 2024
49d5349
Enable #93631
amanasifkhalid Aug 16, 2024
4e68a2d
Enable #75244
amanasifkhalid Aug 16, 2024
cd9c71a
Revert "Enable #73454"
amanasifkhalid Aug 16, 2024
630f4b8
Revert "Enable #8034"
amanasifkhalid Aug 16, 2024
35a0423
Update link
amanasifkhalid Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 8 additions & 44 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
<ExcludeList Include = "$(XunitTestBinBase)/JIT/opt/ValueNumbering/ExposedLocalsNumbering/**">
<Issue>https://github.com/dotnet/runtime/issues/105187</Issue>
</ExcludeList>
<ExcludeList Include = "$(XunitTestBinBase)/JIT/opt/SSA/MemorySsa/**">
<Issue>https://github.com/dotnet/runtime/issues/86112</Issue>
</ExcludeList>
</ItemGroup>

<!-- All OS/Arch CoreCLR excludes -->
Expand Down Expand Up @@ -69,12 +66,6 @@
<ExcludeList Include="$(XunitTestBinBase)/GC/Regressions/Github/Runtime_76219/Runtime_76219/*">
<Issue>https://github.com/dotnet/runtime/issues/78899</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/readytorun/GenericCycleDetection/Depth3Test/*">
<Issue>https://github.com/dotnet/runtime/issues/88586</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/Swift/SwiftInvalidCallConv/*">
<Issue>https://github.com/dotnet/runtime/issues/93631</Issue>
</ExcludeList>
</ItemGroup>

<!-- All Unix targets on all runtimes -->
Expand Down Expand Up @@ -255,9 +246,6 @@
<ExcludeList Include="$(XunitTestBinBase)/baseservices/varargs/varargsupport_r/*">
<Issue>Varargs supported on this platform</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/GitHub_34094/Test34094/*">
<Issue>https://github.com/dotnet/runtime/issues/57458</Issue>
</ExcludeList>
</ItemGroup>

<!-- Windows x86 specific excludes -->
Expand All @@ -281,7 +269,7 @@
<Issue>Depends on implicit tailcalls to be performed</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/DevDiv_255294/DevDiv_255294/*">
<Issue>https://github.com/dotnet/runtime/issues/8034 The test causes OutOfMemory exception in crossgen mode.</Issue>
<Issue>https://github.com/dotnet/runtime/issues/44341 The test causes OutOfMemory exception in crossgen mode.</Issue>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right issue number? #44341 is closed as fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8034 was closed in favor of #44341. I think your PR to improve optReachable (#75990) closed #44341 automatically, and I do not know of an open issue tracking this test. Would you prefer we re-open #44341, or create a new one to track this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test still fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I hit the AV described here when I tried turning it back on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok... I suppose linking to either issue is fine, though #44341 was about a timeout, and #8034 an OOM.

</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/baseservices/varargs/varargsupport/*">
<Issue>Varargs supported on this platform</Issue>
Expand All @@ -292,12 +280,6 @@
<ExcludeList Include="$(XunitTestBinBase)/JIT/jit64/regress/vsw/373472/**">
<Issue>Allocates large contiguous array that is not consistently available on 32-bit platforms</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/GitHub_34094/Test34094/*">
<Issue>https://github.com/dotnet/runtime/issues/57458</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/DictionaryExpansion/DictionaryExpansion/*">
<Issue>https://github.com/dotnet/runtime/issues/75244</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/0582/csgen.1/*">
<Issue>https://github.com/dotnet/runtime/issues/102296</Issue>
</ExcludeList>
Expand Down Expand Up @@ -330,9 +312,6 @@

<!-- The following are x64 Unix failures on CoreCLR. -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(TargetArchitecture)' == 'x64' and '$(TargetsWindows)' != 'true' and '$(RuntimeFlavor)' == 'coreclr'">
<ExcludeList Include="$(XunitTestBinBase)/baseservices/exceptions/simple/ParallelCrashWorkerThreads/*">
<Issue>https://github.com/dotnet/runtime/issues/57621</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/refany/seq_d/*">
<Issue>https://github.com/dotnet/runtime/issues/10478 </Issue>
</ExcludeList>
Expand Down Expand Up @@ -376,9 +355,6 @@

<!-- Unix arm64 specific -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and ('$(TargetArchitecture)' == 'arm64' or '$(AltJitArch)' == 'arm64') and '$(TargetsWindows)' != 'true' and '$(RuntimeFlavor)' == 'coreclr'">
<ExcludeList Include="$(XunitTestBinBase)/tracing/runtimeeventsource/nativeruntimeeventsource/*">
<Issue>https://github.com/dotnet/runtime/issues/68690</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/jit64/eh/FinallyExec/nonlocalexitinhandler/*">
<Issue>Test times out</Issue>
</ExcludeList>
Expand All @@ -401,15 +377,9 @@

<!-- Unix arm32 specific -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and ('$(TargetArchitecture)' == 'arm' or '$(AltJitArch)' == 'arm') and '$(TargetsWindows)' != 'true' and '$(RuntimeFlavor)' == 'coreclr'">
<ExcludeList Include="$(XunitTestBinBase)/tracing/runtimeeventsource/nativeruntimeeventsource/*">
<Issue>https://github.com/dotnet/runtime/issues/68690</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/jit64/regress/vsw/373472/**">
<Issue>Allocates large contiguous array that is not consistently available on 32-bit platforms</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/profiler/multiple/multiple/*">
<Issue>https://github.com/dotnet/runtime/issues/57875</Issue>
</ExcludeList>
</ItemGroup>

<!-- All OSX targets on CoreCLR Runtime -->
Expand Down Expand Up @@ -628,29 +598,26 @@
<!-- Crossgen2 specific -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and ('$(TestBuildMode)' == 'crossgen2' or '$(TestBuildMode)' == 'crossgen') and '$(RuntimeFlavor)' == 'coreclr'">
<ExcludeList Include="$(XunitTestBinBase)/Interop/IJW/NativeVarargs/NativeVarargsTest/*">
<Issue>https://github.com/dotnet/runtime/issues/38096</Issue>
<Issue>https://github.com/dotnet/runtime/issues/83942</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/IJW/CopyConstructorMarshaler/CopyConstructorMarshaler/*">
<Issue>https://github.com/dotnet/runtime/issues/38096</Issue>
<Issue>https://github.com/dotnet/runtime/issues/83942</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/IJW/ManagedCallingNative/ManagedCallingNative/*">
<Issue>https://github.com/dotnet/runtime/issues/38096</Issue>
<Issue>https://github.com/dotnet/runtime/issues/83942</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/IJW/LoadIjwFromModuleHandle/LoadIjwFromModuleHandle/*">
<Issue>https://github.com/dotnet/runtime/issues/38096</Issue>
<Issue>https://github.com/dotnet/runtime/issues/83942</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/IJW/NativeCallingManaged/NativeCallingManaged/*">
<Issue>https://github.com/dotnet/runtime/issues/38096</Issue>
<Issue>https://github.com/dotnet/runtime/issues/83942</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/IJW/FixupCallsHostWhenLoaded/FixupCallsHostWhenLoaded/*">
<Issue>https://github.com/dotnet/runtime/issues/38096</Issue>
<Issue>https://github.com/dotnet/runtime/issues/83942</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/superpmi/superpmicollect/*">
<Issue>Not compatible with crossgen2</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/StructMarshalling/PInvoke/MarshalStructAsLayoutExp/*">
<Issue>https://github.com/dotnet/runtime/issues/43461</Issue>
</ExcludeList>
</ItemGroup>

<!-- Crossgen2 x86 specific excludes -->
Expand Down Expand Up @@ -1209,9 +1176,6 @@
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/CLR-x86-JIT/V1.1-M1-Beta1/b143840/b143840/**">
<Issue>https://github.com/dotnet/runtime/issues/101363</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/CLR-x86-JIT/V1-M10/b08944/b08944b/**">
<Issue>https://github.com/dotnet/runtime/issues/101364</Issue>
</ExcludeList>
</ItemGroup>

<!-- run.proj finds all the *.cmd/*.sh scripts in a test folder and creates corresponding test methods.
Expand Down Expand Up @@ -1751,7 +1715,7 @@
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/reflection/SetValue/TrySetReadonlyStaticField2/**">
<Issue>https://github.com/dotnet/runtime/issues/37903</Issue>
<Issue>https://github.com/dotnet/runtime/issues/97829</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/15241/genericcontext/**">
<Issue>needs triage</Issue>
Expand Down
Loading