Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try re-enabling some CoreCLR/NativeAOT tests #106514

Merged
merged 17 commits into from
Aug 20, 2024
Merged

Try re-enabling some CoreCLR/NativeAOT tests #106514

merged 17 commits into from
Aug 20, 2024

Conversation

amanasifkhalid
Copy link
Member

No description provided.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid
Copy link
Member Author

DevDiv_255294 is failing with an AV in the JIT. Here's a snippet of the stack trace:

314deda4 6be61515 ntdll!KiUserExceptionDispatcher+0xf
314dedc0 6be61559 clrjit_win_x86_x86!ArenaAllocator::allocateMemory+0x65
314dedd0 6be610d6 clrjit_win_x86_x86!ArenaAllocator::MemStatsAllocator::allocateMemory+0x20
314dede0 6be63d06 clrjit_win_x86_x86!CompAllocator::allocate<char>+0xe
314dedf0 6be65c6d clrjit_win_x86_x86!BitVecTraits::Alloc+0x25
314dee0c 6be65d9c clrjit_win_x86_x86!BitSetOps<unsigned int *,1,BitVecTraits *,BitVecTraits>::MakeEmptyArrayBits+0x4e
314dee20 6be65d69 clrjit_win_x86_x86!BitSetOps<unsigned int *,1,BitVecTraits *,BitVecTraits>::MakeSingletonLong+0x2d
314dee38 6becc05f clrjit_win_x86_x86!BitSetOps<unsigned int *,1,BitVecTraits *,BitVecTraits>::MakeSingleton+0x3b
314dee7c 6bfacf90 clrjit_win_x86_x86!BlockReachabilitySets::Build+0x49
314deea4 6be82824 clrjit_win_x86_x86!Compiler::optSetBlockWeights+0x80
314deeb0 6bfaee28 clrjit_win_x86_x86!CompilerPhaseWithStatus::DoPhase+0x14

I'm guessing the allocation fails, and the JIT tries to use the returned pointer, resulting in the AV. So this test is probably still OOM-ing.

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid amanasifkhalid marked this pull request as ready for review August 19, 2024 16:52
@amanasifkhalid
Copy link
Member Author

@dotnet/jit-contrib PTAL. Outerloop failures look like #105441. Should we ping any Crossgen/NativeAOT folks for this, too?

@MichalStrehovsky
Copy link
Member

@dotnet/jit-contrib PTAL. Outerloop failures look like #105441. Should we ping any Crossgen/NativeAOT folks for this, too?

This is deleting the same lines that #105877 already deleted so it's a clean merge no-op. I don't see any other native AOT tests - so LGTM from native AOT perspective.

@amanasifkhalid
Copy link
Member Author

ping @dotnet/jit-contrib

AndyAyersMS
AndyAyersMS reviewed Aug 20, 2024
View reviewed changes
src/tests/issues.targets
@@ -281,7 +269,7 @@
<Issue>Depends on implicit tailcalls to be performed</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/DevDiv_255294/DevDiv_255294/*">
<Issue>https://github.com/dotnet/runtime/issues/8034 The test causes OutOfMemory exception in crossgen mode.</Issue>
<Issue>https://github.com/dotnet/runtime/issues/44341 The test causes OutOfMemory exception in crossgen mode.</Issue>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right issue number? #44341 is closed as fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8034 was closed in favor of #44341. I think your PR to improve optReachable (#75990) closed #44341 automatically, and I do not know of an open issue tracking this test. Would you prefer we re-open #44341, or create a new one to track this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test still fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I hit the AV described here when I tried turning it back on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok... I suppose linking to either issue is fine, though #44341 was about a timeout, and #8034 an OOM.

@amanasifkhalid amanasifkhalid merged commit de3c892 into dotnet:main Aug 20, 2024
117 of 122 checks passed
@amanasifkhalid amanasifkhalid deleted the reenable-tests branch August 20, 2024 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amanasifkhalid @MichalStrehovsky @jkotas @AndyAyersMS