Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some issues impacting the jitstress-isas-x86 runs #104935

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Jul 16, 2024

This resolves the SIMD related issues. There's still a couple of JitStress failures but they aren't related to or unique to the jitstress-isas jobs.

Basically there were two issues aroung AND_NOT handling

  1. When EnableSSE2=0 was set, we'd hit an assert during import of AND_NOT
  2. AND_NOT was hitting the handling for AND, and was being treated as commutative where it shouldn't have been

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 16, 2024
@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tannergooding tannergooding marked this pull request as ready for review July 16, 2024 19:48
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, small fix getting the SIMD related failures for the jitstress-isas jobs all resolved

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tannergooding tannergooding merged commit f1d8613 into dotnet:main Jul 18, 2024
121 of 124 checks passed
@tannergooding tannergooding deleted the fix-isa-stress branch July 18, 2024 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants