-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the Sin, Cos, and SinCos methods on the Vector types #104848
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
33bc061
to
1a86ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is blocked on the JIT side fix going in (#104935) |
Noting that the regression is "by design" in that we took an accuracy fix to ensure we were overall consistent with the scalar algorithm If the input is less then 5 million then we are generally fast and if its less PI / 4 (already reduced) then we are very fast. However, if the input is greater than 5 million we fallback to scalar currently. This is something we can fix, but it was out of scope for .NET 10 since such inputs should be rare. |
This makes additional progress towards #93513
This implementation is more accurate than the naive implementation that TensorPrimitives had been using and correctly handles the full range of inputs. It does still fallback to scalar if any input is greater than 5 million as vectorizing the complex reduction is more involved and I want to handle it separately in .NET 10.