Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanify some Utf8String and Utf8StringBuilder use #102101

Merged
merged 26 commits into from
May 14, 2024
Merged

Spanify some Utf8String and Utf8StringBuilder use #102101

merged 26 commits into from
May 14, 2024

Commits on May 10, 2024

  1. Address TODOs

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    56490e8 View commit details
    Browse the repository at this point in the history

  2. Make Utf8String readonly

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ea1e855 View commit details
    Browse the repository at this point in the history

  3. Make Utf8StringBuilder.Append do two Encoding.UTF8 calls instead of many 

    * The quick is-valid-ascii check in UTF8 encoding _hopefully_ makes this worth the simplification, even though 99% of the inputs are just ASCII. I'm ready to revert this.
    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bc4e50e View commit details
    Browse the repository at this point in the history

  4. Use UTF8 literals for the appended constant strings in ILC

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ca24552 View commit details
    Browse the repository at this point in the history

  5. Use UTF8 literals for the appended constant strings in R2R

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8d3e0db View commit details
    Browse the repository at this point in the history

  6. Use pattern match in Utf8String.Equals(object)

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7431393 View commit details
    Browse the repository at this point in the history

  7. Use SequenceEquals in Utf8String.Equals(Utf8String)

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bd9e6ef View commit details
    Browse the repository at this point in the history

  8. Use CommonPrefixLength in Utf8String.Compare(Utf8String, Utf8String) 

    * Very much inspired (copied) from dotnet#75851
    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cb0eb90 View commit details
    Browse the repository at this point in the history

  9. Remove unused Utf8StringBuilder.LastCharBoundary

    @PaulusParssinen
    PaulusParssinen committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2ed3a64 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Remove Utf8StringBuilder.UnderlyingArray 

    Co-authored-by: Jan Kotas <[email protected]>
    @PaulusParssinen @jkotas
    PaulusParssinen and jkotas authored May 11, 2024
    Configuration menu
    Copy the full SHA
    ace1494 View commit details
    Browse the repository at this point in the history

  2. Revert "Remove Utf8StringBuilder.UnderlyingArray" 

    This reverts commit ace1494.

It was used by DwarfEhFrame.cs
    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0002c62 View commit details
    Browse the repository at this point in the history

  3. Use SequenceCompareTo

    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    fe86998 View commit details
    Browse the repository at this point in the history

  4. UnderlyingArray -> AsSpan()

    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    51b63e3 View commit details
    Browse the repository at this point in the history

  5. Only return filled-portion of the buffer in Utf8StringBuilder.AsSpan 

    Co-authored-by: Jan Kotas <[email protected]>
    @PaulusParssinen @jkotas
    PaulusParssinen and jkotas authored May 11, 2024
    Configuration menu
    Copy the full SHA
    bafd05f View commit details
    Browse the repository at this point in the history

  6. Write null-terminator for the augmentationString.

    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    77a600d View commit details
    Browse the repository at this point in the history

  7. Utf8StringBuilder.Append(char) -> Utf8StringBuilder.Append(byte) 

    * Only ASCII constant chars we're passed to this method
    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    2e050a3 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary cast

    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    5dd1cbf View commit details
    Browse the repository at this point in the history

  9. Update src/coreclr/tools/Common/Internal/Text/Utf8StringBuilder.cs 

    Co-authored-by: Paulus Pärssinen <[email protected]>
    @jkotas @PaulusParssinen
    jkotas and PaulusParssinen authored May 11, 2024
    Configuration menu
    Copy the full SHA
    19106c7 View commit details
    Browse the repository at this point in the history

  10. Update src/coreclr/tools/Common/Internal/Text/Utf8StringBuilder.cs 

    Co-authored-by: Paulus Pärssinen <[email protected]>
    @jkotas @PaulusParssinen
    jkotas and PaulusParssinen authored May 11, 2024
    Configuration menu
    Copy the full SHA
    00d4e54 View commit details
    Browse the repository at this point in the history

  11. Use UTF8 literals for single characters too

    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    8a97513 View commit details
    Browse the repository at this point in the history

  12. Revert "Use UTF8 literals for single characters too" 

    This reverts commit 8a97513.
    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    bb4477b View commit details
    Browse the repository at this point in the history

  13. Revert "Remove unnecessary cast" 

    This reverts commit 5dd1cbf.
    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7838413 View commit details
    Browse the repository at this point in the history

  14. Revert "Utf8StringBuilder.Append(char) -> Utf8StringBuilder.Append(by… 

    …te)"

This reverts commit 2e050a3.
    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    1f80778 View commit details
    Browse the repository at this point in the history

  15. Add Ascii.IsValid assert to Utf8StringBuilder.Append

    @PaulusParssinen
    PaulusParssinen committed May 11, 2024
    Configuration menu
    Copy the full SHA
    b7c0fdb View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into spanify-internal-text-utf8string

    @jkotas
    jkotas authored May 11, 2024
    Configuration menu
    Copy the full SHA
    ae917bc View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'main' into spanify-internal-text-utf8string

    @MichalStrehovsky
    MichalStrehovsky authored May 13, 2024
    Configuration menu
    Copy the full SHA
    b007b64 View commit details
    Browse the repository at this point in the history