Use CommonPrefixLength for SetOf sort validation #75851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
CommonPrefixLength
is optimized and vectorized, this gives a small perf bump when validating ASN.1 SetOf sorting for "large" (greater than 16 elements). For small inputs the perf change is negligible.Note in the table below for
SetOf_CorrectSort
, it shows as being 1ns slower, but other runs it ends up coming out faster, but all within a ns of each other.