-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT ABI stress test: Assertions on Arm32 #68837
Comments
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsDescriptionPlaceholder until #67917 is in. These failures started when Two asserts in 4 tests:
Reproduction StepsRun the JIT Stress tests on Ubuntu ubuntu-18.04 arm32. Expected behaviorNo Asserts. Actual behaviorAsserts:
Regression?No response Known WorkaroundsNo response Configurationdocker image mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440 on ddvsotx2l132 Other informationNo response
|
* JIT ARM32: Fix odd sized structs from arbitrary sources ARM32 ABI allows passing structs in register even when their sizes are not divisible by 4. This means we sometimes need to pass 3 bytes in the last register. The JIT would not handle this when the source was an arbitrary memory location (this would require multiple loads and shifts). The fix is to just force a copy into the local stack frame for this case. Fix #61168 * Reenable ABI tests Fix #68837 Fix #70042
Description
Changes made in #67917 are now causing test failures, although the issues are in the JIT not by that PR. The test failures started when that PR added support for
DynamicMethod.Invoke()
(which the JIT tests use) to use IL Emit to generate the code to perform the invoke (instead of native code).Two asserts in 4 tests:
Reproduction Steps
Run the JIT Stress tests on Ubuntu ubuntu-18.04 arm32.
Expected behavior
No Asserts.
Actual behavior
Asserts:
Regression?
No response
Known Workarounds
No response
Configuration
docker image mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440 on ddvsotx2l132
Other information
No response
The text was updated successfully, but these errors were encountered: