ARM32 JIT: Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' during 'Morph - Global' #61168

jakobbotsch · 2021-11-03T16:13:14Z

Description

The following program hits a NYI in the ARM32 JIT.

Reproduction Steps

// Generated by Fuzzlyn v1.5 on 2021-11-03 13:28:03
// Run on Arm Linux
// Seed: 6887874265338996715
// Reduced from 122.0 KiB to 0.4 KiB in 00:02:32
// Hits JIT assert in Debug:
// Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' in 'Program:Main(Fuzzlyn.ExecutionServer.IRuntime)' during 'Morph - Global' (IL size 20)
// 
//     File: /__w/1/s/src/coreclr/jit/morph.cpp Line: 4382
// 
public struct S0
{
    public byte F0;
    public sbyte F1;
    public bool F2;
    public byte F3;
    public byte F4;
    public byte F5;
    public sbyte F6;
}

public class Program
{
    public static S0 s_4;
    public static void Main()
    {
        ref S0 vr0 = ref s_4;
        M35(vr0);
    }

    public static void M35(S0 arg0)
    {
    }
}

Expected behavior

No assert hit

Actual behavior

Assert hit

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

cc @dotnet/jit-contrib

ghost · 2021-11-03T16:13:18Z

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

The following program hits a NYI in the ARM32 JIT.

Reproduction Steps

// Generated by Fuzzlyn v1.5 on 2021-11-03 13:28:03
// Run on Arm Linux
// Seed: 6887874265338996715
// Reduced from 122.0 KiB to 0.4 KiB in 00:02:32
// Hits JIT assert in Debug:
// Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' in 'Program:Main(Fuzzlyn.ExecutionServer.IRuntime)' during 'Morph - Global' (IL size 20)
// 
//     File: /__w/1/s/src/coreclr/jit/morph.cpp Line: 4382
// 
public struct S0
{
    public byte F0;
    public sbyte F1;
    public bool F2;
    public byte F3;
    public byte F4;
    public byte F5;
    public sbyte F6;
}

public class Program
{
    public static S0 s_4;
    public static void Main()
    {
        ref S0 vr0 = ref s_4;
        M35(vr0);
    }

    public static void M35(S0 arg0)
    {
    }
}

Expected behavior

No assert hit

Actual behavior

Assert hit

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

cc @dotnet/jit-contrib

Author:	jakobbotsch
Assignees:	-
Labels:	`arch-arm32`, `area-CodeGen-coreclr`
Milestone:	-

VincentBu · 2022-05-24T01:09:45Z

Failed again in: runtime-coreclr outerloop 20220523.2

Failed test:

R2R-CG2 windows arm Checked no_tiered_compilation @ Windows.10.Arm64v8.Open

- JIT\\Stress\\ABI\\tailcalls_do\\tailcalls_do.cmd
- JIT\\Stress\\ABI\\tailcalls_d\\tailcalls_d.cmd

coreclr windows arm Checked no_tiered_compilation @ Windows.10.Arm64v8.Open

- JIT\\Stress\\ABI\\tailcalls_do\\tailcalls_do.cmd
- JIT\\Stress\\ABI\\tailcalls_d\\tailcalls_d.cmd

Error message:

Assert failure(PID 3068 [0x00000bfc], Thread: 7108 [0x1bc4]): Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' in 'DynamicClass:InvokeStub_ABIStress_TailCallee9685(System.Object,System.Object,int):System.Object' during 'Morph - Global' (IL size 68; hash 0x3dc7e6f8; FullOpts)

File: D:\a\_work\1\s\src\coreclr\jit\morph.cpp Line: 3853
Image: D:\h\w\942D0818\p\corerun.exe
Return code:      1
Raw output file:      D:\h\w\942D0818\w\B70709A5\uploads\Reports\JIT.Stress\ABI\tailcalls_do\tailcalls_do.output.txt
Raw output:
BEGIN EXECUTION
tailcalls_do.dll
1 file(s) copied.
13:42:30.59
Response file: D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll.rsp
D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\IL-CG2\tailcalls_do.dll
-o:D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll
--targetarch:arm
--verify-type-and-field-layout
--method-layout:random
-r:D:\h\w\942D0818\p\System..dll
-r:D:\h\w\942D0818\p\Microsoft..dll
-r:D:\h\w\942D0818\p\mscorlib.dll
-r:D:\h\w\942D0818\p\netstandard.dll
-O
" "dotnet" "D:\h\w\942D0818\p\crossgen2\crossgen2.dll" @"D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll.rsp"   -r:D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\IL-CG2*.dll"
Emitting R2R PE file: D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll
13:42:33.16
"D:\h\w\942D0818\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  tailcalls_do.dll --tailcalls --num-calls 1000 --no-ctrlc-summary
Stressing tailcalls
OSVersion: Microsoft Windows NT 10.0.19044.0
OSArchitecture: Arm64
ProcessArchitecture: Arm
Selecting win86 ABI
50 callers done (49 successful tailcalls tested)
100 callers done (99 successful tailcalls tested)
150 callers done (149 successful tailcalls tested)
200 callers done (199 successful tailcalls tested)
250 callers done (250 successful tailcalls tested)
300 callers done (300 successful tailcalls tested)
350 callers done (350 successful tailcalls tested)
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=D:\h\w\942D0818\p
D:\h\w\942D0818\w\B70709A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.cmd
Expected: True
Actual:   False


Stack trace
   at JIT_Stress._ABI_tailcalls_do_tailcalls_do_._ABI_tailcalls_do_tailcalls_do_cmd()

jakobbotsch · 2022-05-31T19:09:32Z

I can take a look at this one @kunalspathak

BruceForstall · 2022-05-31T20:15:51Z

Note: #70043

VincentBu · 2022-06-01T01:17:48Z

Failed again in: runtime-coreclr outerloop 20220531.2

Failed test:

R2R-CG2 windows arm Checked no_tiered_compilation @ Windows.10.Arm64v8.Open

- JIT\\Stress\\ABI\\tailcalls_do\\tailcalls_do.cmd
- JIT\\Stress\\ABI\\tailcalls_d\\tailcalls_d.cmd

coreclr windows arm Checked no_tiered_compilation @ Windows.10.Arm64v8.Open

- JIT\\Stress\\ABI\\tailcalls_do\\tailcalls_do.cmd
- JIT\\Stress\\ABI\\tailcalls_d\\tailcalls_d.cmd

Error message:

Assert failure(PID 15228 [0x00003b7c], Thread: 7032 [0x1b78]): Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' in 'DynamicClass:InvokeStub_ABIStress_TailCallee9685(System.Object,System.Object,int):System.Object' during 'Morph - Global' (IL size 68; hash 0x3dc7e6f8; FullOpts)

File: D:\a\_work\1\s\src\coreclr\jit\morph.cpp Line: 3847
Image: D:\h\w\9EA608E0\p\corerun.exe
Return code:      1
Raw output file:      D:\h\w\9EA608E0\w\B79809A5\uploads\Reports\JIT.Stress\ABI\tailcalls_do\tailcalls_do.output.txt
Raw output:
BEGIN EXECUTION
tailcalls_do.dll
1 file(s) copied.
13:36:36.27
Response file: D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll.rsp
D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\IL-CG2\tailcalls_do.dll
-o:D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll
--targetarch:arm
--verify-type-and-field-layout
--method-layout:random
-r:D:\h\w\9EA608E0\p\System..dll
-r:D:\h\w\9EA608E0\p\Microsoft..dll
-r:D:\h\w\9EA608E0\p\mscorlib.dll
-r:D:\h\w\9EA608E0\p\netstandard.dll
-O
" "dotnet" "D:\h\w\9EA608E0\p\crossgen2\crossgen2.dll" @"D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll.rsp"   -r:D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\IL-CG2*.dll"
Emitting R2R PE file: D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.dll
13:36:39.89
"D:\h\w\9EA608E0\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  tailcalls_do.dll --tailcalls --num-calls 1000 --no-ctrlc-summary
Stressing tailcalls
OSVersion: Microsoft Windows NT 10.0.19044.0
OSArchitecture: Arm64
ProcessArchitecture: Arm
Selecting win86 ABI
50 callers done (46 successful tailcalls tested)
100 callers done (100 successful tailcalls tested)
150 callers done (150 successful tailcalls tested)
200 callers done (199 successful tailcalls tested)
250 callers done (250 successful tailcalls tested)
300 callers done (299 successful tailcalls tested)
350 callers done (350 successful tailcalls tested)
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=D:\h\w\9EA608E0\p
D:\h\w\9EA608E0\w\B79809A5\e\JIT\Stress\ABI\tailcalls_do\tailcalls_do.cmd
Expected: True
Actual:   False


Stack trace
   at JIT_Stress._ABI_tailcalls_do_tailcalls_do_._ABI_tailcalls_do_tailcalls_do_cmd()

ARM32 ABI allows passing structs in register even when their sizes are not divisible by 4. This means we sometimes need to pass 3 bytes in the last register. The JIT would not handle this when the source was an arbitrary memory location (this would require multiple loads and shifts). The fix is to just force a copy into the local stack frame for this case. Fix dotnet#61168

* JIT ARM32: Fix odd sized structs from arbitrary sources ARM32 ABI allows passing structs in register even when their sizes are not divisible by 4. This means we sometimes need to pass 3 bytes in the last register. The JIT would not handle this when the source was an arbitrary memory location (this would require multiple loads and shifts). The fix is to just force a copy into the local stack frame for this case. Fix #61168 * Reenable ABI tests Fix #68837 Fix #70042

jakobbotsch added arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Nov 3, 2021

dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 3, 2021

JulieLeeMSFT assigned kunalspathak Nov 3, 2021

JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Nov 3, 2021

JulieLeeMSFT added this to the 7.0.0 milestone Nov 3, 2021

jakobbotsch mentioned this issue May 4, 2022

JIT ABI stress test: Assertions on Arm32 #68837

Closed

jakobbotsch mentioned this issue May 14, 2022

Test failure JIT\\Stress\\ABI\\tailcalls_do\\tailcalls_do.cmd #69090

Closed

jkotas mentioned this issue May 15, 2022

Fix UTF8 string marshalling regression #69360

Merged

jakobbotsch mentioned this issue May 31, 2022

[Windows arm] JIT/stress/ABI/tailcall_d / do tests are non-deterministically failing several times a day #70042

Closed

jakobbotsch assigned jakobbotsch and unassigned kunalspathak May 31, 2022

jakobbotsch mentioned this issue Jun 1, 2022

JIT ARM32: Fix passing odd sized structs from arbitrary sources #70075

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 1, 2022

jakobbotsch closed this as completed in #70075 Jun 7, 2022

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 7, 2022

ghost locked as resolved and limited conversation to collaborators Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM32 JIT: Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' during 'Morph - Global' #61168

ARM32 JIT: Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' during 'Morph - Global' #61168

jakobbotsch commented Nov 3, 2021

ghost commented Nov 3, 2021

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

VincentBu commented May 24, 2022

jakobbotsch commented May 31, 2022

BruceForstall commented May 31, 2022

VincentBu commented Jun 1, 2022

ARM32 JIT: Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' during 'Morph - Global' #61168

ARM32 JIT: Assertion failed '!"NYI: odd sized struct in fgMorphMultiregStructArg"' during 'Morph - Global' #61168

Comments

jakobbotsch commented Nov 3, 2021

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

ghost commented Nov 3, 2021

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

VincentBu commented May 24, 2022

jakobbotsch commented May 31, 2022

BruceForstall commented May 31, 2022

VincentBu commented Jun 1, 2022